Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make bucket configurable #5

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: make bucket configurable #5

wants to merge 1 commit into from

Conversation

raae
Copy link
Contributor

@raae raae commented Jan 20, 2024

I imagine one would like a staging bucket, dev bucket, etc., and just in general, it would be nice to configure the bucket.

Sh4yy
Sh4yy reviewed Jan 29, 2024
View reviewed changes
Copy link
Owner

@Sh4yy Sh4yy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks so much.

Could you add the new env variable to the Readme file as well please? 🙏🏻

@raae
Copy link
Contributor Author

raae commented Feb 2, 2024

Will do and I'll fix merge conflicts!

@raae raae force-pushed the feat/make-bucket-configurable branch from dbad091 to 70fe091 Compare February 3, 2024 08:05
@raae
Copy link
Contributor Author

raae commented Feb 3, 2024 •
edited
Loading

It should be good to go now @Sh4yy

@raae
Copy link
Contributor Author

raae commented Feb 10, 2024

Any other things needed before it gets merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sh4yy Sh4yy Sh4yy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raae @Sh4yy