Set to/from token prices to zero if CoinGecko price fetch fails #81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Especially on Polygon, CoinGecko price requests return an empty object for some (liquid) tokens, crashing the quote API
In the initial TradeQuoter review Alex suggested we set the price as
0
when this happens as a way of failing gracefully. (#61).Would that work for set-ui, or is there a more convenient default value?
Example response with zero values: