Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ETH compatibility to AaveV2WrapV2Adapter #262

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bergben
Copy link

@bergben bergben commented Sep 20, 2022

Adds the WETHGateway to the AaveV2WrapV2Adapter so that it behaves the same way as the CompoundWrapV2Adapter.

I thought ensuring behavior across integrations reduces some complexity

Rebasing could be a problem, that has to be researched further. I asked on the discord because there is some conflicting information:

  • In the FAQ it says that Set tokens do not support rebasing tokens
  • In the docs it says

Another caveat to be aware of in the current interaction of Set is that any asset that you want to include must not be a Rebasing token or one with a Transfer Fee associated with it. The issue here is that these token properties are not compatible with the contract assumptions of a Set being 100% collateralised at present.

the wrap module would add support for tokens that don't fulfill the liquidity requirement

I tried to ask for more details on discord

@bergben bergben changed the title feat(integrations): add ETH compatibility to AaveV2WrapV2Adapter add ETH compatibility to AaveV2WrapV2Adapter Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant