CurveAmmAdapter #259
CurveAmmAdapter #259
Conversation
| poolMinter = _poolMinter; | ||
| isCurveV1 = _isCurveV1; | ||
| coinCount = _coinCount; | ||
| for (uint256 i = 0 ; i < _coinCount ; ++i) { |
There was a problem hiding this comment.
Is it possible to execute these functions without storing coins and coinIndex?
There was a problem hiding this comment.
this coins and coinIndex is to used to check if component token is valid. without storing coins and coinIndex, it will require more gas each time trying to get calldata.
| ) public { | ||
| poolToken = _poolToken; | ||
| poolMinter = _poolMinter; | ||
| isCurveV1 = _isCurveV1; |
There was a problem hiding this comment.
Is there a way to ensure that the contract passed in is curveV1 or curveV2?
There was a problem hiding this comment.
there is no proper way to check the interface
|
I've only looked closely at the contract so far, leaving a more detailed look to the tests later |
| params: [ | ||
| { | ||
| forking: { | ||
| jsonRpcUrl: `https://eth-mainnet.alchemyapi.io/v2/${process.env.ALCHEMY_TOKEN}`, |
There was a problem hiding this comment.
if it's mainnet - isn't hardhat already set up for forking?
| } | ||
|
|
||
| const expectedNewLpTokens = | ||
| coinCount === 2 |
There was a problem hiding this comment.
Use a switch statement here for readability
| // `calc_token_amount` of `USDT/WBTC/WETH` pool return correct amount out for add_liquidity, but it doesn't return for `MIM/3CRV` pools. | ||
| // there is some external logic for fees, here we test actual output and expected output with 0.1% slippage | ||
| expectCloseTo( | ||
| (await poolToken.balanceOf(setToken.address)).sub(lpBalanceBefore), |
There was a problem hiding this comment.
Extract this out to separate variable
| let ammModule: AmmModule; | ||
|
|
||
| before(async () => { | ||
| await network.provider.request({ |
There was a problem hiding this comment.
Since this is unit test, shouldn't need these hardhat fork setup
There are a few things to consider about the CurveAmmAdapter.
All curve pools have 2 ~ 4 component coins.
CVXETH - 0x3A283D9c08E8b55966afb64C515f5143cf907611 (two tokens - WETH/CVX)
TRICRYPTO - 0xc4AD29ba4B3c580e6D59105FFf484999997675Ff (three tokens - USDT/WBTC/WETH)
There is no generalized query function to get component coin count of the pool.
To support different number of component coins, the CurveAmmAdapter will accept
coinCountin constructor.Each curve pool has token contract (which has IERC20 standard interface) and minter contract (which has addLiquidity / removeLiquidity functionality).
Example curve pool with different token/minter contract address
CVXETH token contract - 0x3A283D9c08E8b55966afb64C515f5143cf907611
CVXETH minter contract - 0xb576491f1e6e5e62f1d8f26062ee822b40b0e0d4
Example curve pool with same token/minter contract address
MIM token contract - 0x5a6A4D54456819380173272A5E8E9B9904BdF41B
MIM minter contract - 0x5a6A4D54456819380173272A5E8E9B9904BdF41B
Since some has the same token/minter contract and some has different token/minter contract, the CurveAmmAdapter will accept
poolTokenandpoolMintercontract addresses in constructor.The curve pools support
removeLiquidityOneCoinfunctionality, but some pools useint128for the coin index, some pools useuint256for the coin index.MIM token contract - 0x5a6A4D54456819380173272A5E8E9B9904BdF41B (use
int128for the coin index)TRICRYPTO - 0xc4AD29ba4B3c580e6D59105FFf484999997675Ff (use
uint256for the coin index)To solve this problem, the CurveAmmAdapter will accept a flag that tells if the pool uses
int128oruint256for coin index.The curve pools has addLiquidity and removeLiquidity functionality but it doesn't accept any recipient address. So we can't specify setToken address in the calldata.
This is fixed by introducing
addLiquidity,removeLiquidityandremoveLiquidityOneCoinwrapper functions in CurveAmmAdapter contract.E.g. addLiquidity wrapper function will accept the recipient address. It will get component tokens from msg.sender, add liquidity & mint pool tokens, transfer pool tokens back to recipient address.