Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VelodromeExchangeAdapter #257

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

VelodromeExchangeAdapter #257

wants to merge 10 commits into from

Conversation

andris-balodis
Copy link

@FlattestWhite
Copy link
Contributor

Also looks like the integration tests are failing on CI

FlattestWhite
FlattestWhite reviewed Jun 29, 2022
View reviewed changes
contracts/interfaces/external/IVelodromeRouter.sol Outdated Show resolved Hide resolved
test/protocol/integration/exchange/velodromeExchangeAdapter.spec.ts Outdated Show resolved Hide resolved
contracts/protocol/integration/exchange/VelodromeExchangeAdapter.sol Show resolved Hide resolved
test/protocol/integration/exchange/velodromeExchangeAdapter.spec.ts Outdated Show resolved Hide resolved
contracts/protocol/integration/exchange/VelodromeExchangeAdapter.sol Outdated Show resolved Hide resolved
test/protocol/integration/exchange/velodromeExchangeAdapter.spec.ts Outdated Show resolved Hide resolved
test/protocol/integration/exchange/velodromeExchangeAdapter.spec.ts Outdated Show resolved Hide resolved
test/protocol/integration/exchange/velodromeExchangeAdapter.spec.ts Show resolved Hide resolved
FlattestWhite
FlattestWhite reviewed Jun 29, 2022
View reviewed changes
Copy link
Contributor

@FlattestWhite FlattestWhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly looks pretty good - I'm just wondering with all the extra interface objects, where they are needed. I was under the impression only the abi json files are required

contracts/protocol/integration/exchange/VelodromeExchangeAdapter.sol Show resolved Hide resolved
utils/deploys/deployAdapters.ts Outdated Show resolved Hide resolved
test/integration/velodromeExchangeTradeModule.spec.draft.ts Show resolved Hide resolved
utils/deploys/deployExternal.ts Outdated Show resolved Hide resolved
external/contracts/velodrome/VelodromePair.sol Outdated Show resolved Hide resolved
external/contracts/velodrome/interfaces/IERC20.sol Outdated Show resolved Hide resolved
external/contracts/velodrome/lib/Math.sol Outdated Show resolved Hide resolved
test/integration/velodromeExchangeTradeModule.spec.draft.ts Show resolved Hide resolved
FlattestWhite
FlattestWhite reviewed Jun 30, 2022
View reviewed changes
Copy link
Contributor

@FlattestWhite FlattestWhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nearly there - a few more comments on the style of the unit test to be consistent with set's expected style

test/protocol/integration/exchange/velodromeExchangeAdapter.spec.ts Outdated Show resolved Hide resolved
utils/test/index.ts Outdated Show resolved Hide resolved
utils/fixtures/velodromeFixture.ts Outdated Show resolved Hide resolved
utils/contracts/velodrome.ts Outdated Show resolved Hide resolved
test/protocol/integration/exchange/velodromeExchangeAdapter.spec.ts Outdated Show resolved Hide resolved
@andris-balodis andris-balodis marked this pull request as ready for review June 30, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlattestWhite FlattestWhite FlattestWhite approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andris-balodis @FlattestWhite