update issuance modules #178
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new BasicIssuanceModuleV2 and update DebtIssuanceModule and DebtIssuanceModuleV2 to call manager pre-redeem hooks and allow managers to update these hooks.
One change that ended up propagating to SlippageIssuanceModule was that I had to set the managerIssuanceHook parameter of SetTokenRedeemed to address(0) since the hook is never called for redeem. An alternative solution I tried was to override the event in SlippageIssuanceModule to remove this parameter, which compiles correctly but hardhat seems to dislike when two events have the same name. This same issue cropped up in BasicIssuanceModule