Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0.7 Release #70

Open
wants to merge 76 commits into
base: main
Choose a base branch
from
Open

1.0.7 Release #70

wants to merge 76 commits into from

Conversation

willtome
Copy link
Collaborator

No description provided.

willtome and others added 30 commits February 28, 2020 21:57
* add enhanced mode to inventory. update readme.

* throw error if update set not installed
Check for missing commits vs ansible/ansible devel
* add enhanced mode to inventory. update readme.

* throw error if update set not installed
Check for missing commits vs ansible/ansible devel
* add docs for inventory plugin

* add docs for modules
* add release automation

* fix for CI. duplicate fix from PR #15. Closes issue #14
* remove unrecognized keyword. issue #14

* fix CI
@willtome willtome changed the title Release 1.0.7 1.0.7 Release Sep 13, 2021
@willtome willtome requested a review from amittell September 13, 2021 16:47
@hugotomasi
Copy link

Hello,

I would like to know if there is a release date for this release as I need to use variable from related tables (#45).

Best regards.

@willtome
Copy link
Collaborator Author

@dmsimard thanks for catching the typos but that doesn't seem to be tripping up CI. Something about keys but I can't find any good documentation on what needs to agree as the failures are indicating.

@dmsimard
Copy link

Hi @willtome and thanks for trying to add the deprecation notices in.

I spotted the typos while trying to understand the failures.

I think it's unhappy about being deprecated in the modules but removed (tombstone) in the meta/runtime.yml file.

Could you try replacing tombstone by deprecation and see if that works ?

@dmsimard
Copy link

That last commit fixed the errors I saw and we got new ones now:

ERROR: Found 2 validate-modules issue(s) which need to be resolved:
ERROR: plugins/modules/snow_record.py:0:0: invalid-documentation: DOCUMENTATION.deprecated.alternative: required key not provided @ data['deprecated']['alternative']. Got None
ERROR: plugins/modules/snow_record_find.py:0:0: invalid-documentation: DOCUMENTATION.deprecated.alternative: required key not provided @ data['deprecated']['alternative']. Got None

This time ansible-test wants an extra 'alternative' field in the doc_fragment bit you added.
This should ideally be the equivalent modules in the other collection -- there's more info in the docs.

It is my understanding that the field is free-text so it doesn't need to be exactly the module name either.

@dmsimard
Copy link

dmsimard commented Nov 1, 2021

@willtome do you have what you need to see this PR to completion ?

@hugotomasi
Copy link

Hello,

Do you have an update on the completion of this PR ?

Best regards.

@marek1712
Copy link

@amittell @willtome - any chance for another review?

@willtome
Copy link
Collaborator Author

willtome commented Dec 8, 2022

This collection has been deprecated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.