Add analyzer for input arguments for all 'D2D' intrinsics #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergio0694
force-pushed
the
dev/d2d-intrinsic-analyzer
branch
from
41b47ad
to
3e6ea4e
Compare
rickbrew
requested changes
Nov 23, 2024
src/ComputeSharp.D2D1.SourceGenerators/Diagnostics/Analyzers/InvalidD2DInputArgumentAnalyzer.cs
Outdated
Show resolved
Hide resolved
src/ComputeSharp.D2D1.SourceGenerators/Diagnostics/Analyzers/InvalidD2DInputArgumentAnalyzer.cs
Outdated
Show resolved
Hide resolved
src/ComputeSharp.D2D1.SourceGenerators/Diagnostics/Analyzers/InvalidD2DInputArgumentAnalyzer.cs
Outdated
Show resolved
Hide resolved
...ComputeSharp.D2D1.Tests.SourceGenerators/Test_D2DPixelShaderDescriptorGenerator_Analyzers.cs
Show resolved
Hide resolved
Sergio0694
force-pushed
the
dev/d2d-intrinsic-analyzer
branch
2 times, most recently
from
bbe3976
to
49d9268
Compare
Sergio0694
force-pushed
the
dev/d2d-intrinsic-analyzer
branch
from
49d9268
to
984f834
Compare
rickbrew
requested changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #769
Description
This PR adds a new analyzer to emit errors if:
D2DAPI is used with an index out of range for the shaderD2DAPI is used with a shader input of an invalid typeExample