refactor: Remove unused variables from function signature

Signed-off-by: Sergiy Kulanov <[email protected]>
SergK · Oct 13, 2023 · d47766c · d47766c
1 parent 62d49cd
commit d47766c
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 10 deletions.
diff --git a/go.mod b/go.mod
@@ -84,7 +84,7 @@ require (
 	github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect
 	github.com/modern-go/reflect2 v1.0.2 // indirect
 	github.com/spf13/cobra v1.7.0
-	github.com/spf13/pflag v1.0.5
+	github.com/spf13/pflag v1.0.5 // indirect
 	github.com/tektoncd/pipeline v0.52.0
 	golang.org/x/net v0.17.0 // indirect
 	golang.org/x/oauth2 v0.11.0 // indirect

diff --git a/pkg/cmd/graphutil/graphutil.go b/pkg/cmd/graphutil/graphutil.go
@@ -61,7 +61,7 @@ func NewGraphCommand(p cli.Params, runE func(cmd *cobra.Command, args []string,
 	return c
 }
 
-func RunGraphCommand(cmd *cobra.Command, args []string, p cli.Params, opts *GraphOptions, fetcher GraphFetcher) error {
+func RunGraphCommand(args []string, p cli.Params, opts *GraphOptions, fetcher GraphFetcher) error {
 	cs, err := p.Clients()
 	if err != nil {
 		return err

diff --git a/pkg/cmd/graphutil/graphutil_test.go b/pkg/cmd/graphutil/graphutil_test.go
@@ -91,9 +91,7 @@ func TestRunGraphCommand(t *testing.T) {
 				WithTaskRef:  false,
 			}
 
-			cmd := &cobra.Command{}
-
-			err := graphutil.RunGraphCommand(cmd, []string{}, p, opts, fetcher)
+			err := graphutil.RunGraphCommand([]string{}, p, opts, fetcher)
 
 			if tt.expectingError && err == nil {
 				t.Errorf("Expected an error, got nil")
@@ -122,9 +120,7 @@ func TestRunGraphCommand_ErrorFetcher(t *testing.T) {
 		WithTaskRef:  false,
 	}
 
-	cmd := &cobra.Command{}
-
-	err := graphutil.RunGraphCommand(cmd, []string{}, p, opts, fetcher)
+	err := graphutil.RunGraphCommand([]string{}, p, opts, fetcher)
 
 	if err == nil {
 		t.Errorf("Expected an error, got nil")

diff --git a/pkg/cmd/pipeline/graph.go b/pkg/cmd/pipeline/graph.go
@@ -12,7 +12,7 @@ import (
 
 func graphCommand(p cli.Params) *cobra.Command {
 	return graphutil.NewGraphCommand(p, func(cmd *cobra.Command, args []string, p cli.Params, opts *graphutil.GraphOptions) error {
-		return graphutil.RunGraphCommand(cmd, args, p, opts, func(cs *cli.Clients, args []string, namespace string) ([]graphutil.GraphData, error) {
+		return graphutil.RunGraphCommand(args, p, opts, func(cs *cli.Clients, args []string, namespace string) ([]graphutil.GraphData, error) {
 			var pipelines []v1.Pipeline
 			var err error
 

diff --git a/pkg/cmd/pipelinerun/graph.go b/pkg/cmd/pipelinerun/graph.go
@@ -12,7 +12,7 @@ import (
 
 func graphCommand(p cli.Params) *cobra.Command {
 	return graphutil.NewGraphCommand(p, func(cmd *cobra.Command, args []string, p cli.Params, opts *graphutil.GraphOptions) error {
-		return graphutil.RunGraphCommand(cmd, args, p, opts, func(cs *cli.Clients, args []string, namespace string) ([]graphutil.GraphData, error) {
+		return graphutil.RunGraphCommand(args, p, opts, func(cs *cli.Clients, args []string, namespace string) ([]graphutil.GraphData, error) {
 			var pipelineruns []v1.PipelineRun
 			var err error