Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for "Move Workspace File" API Endpoint #15

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

neves-nvs
Copy link

@neves-nvs neves-nvs commented Oct 22, 2024

Summary:
This pull request introduces an ad-hoc implementation to interact with an additional endpoint of the SendSafely API that is currently not supported by this package. The existing Python package for SendSafely does not expose this endpoint, so I’ve implemented the necessary functionality to support interactions with it. This was added based on our specific needs for file management within workspaces.

Changes Made:

  • Added a new method to the Package class to interact with the previously unsupported "Move Workspace File" API endpoint.
  • Added the corresponding exception class MoveFileException to handle errors related to this operation.

Notes:

  • The additions are:

    • Package.move_file_to_directory(self, file_id, directory_id)
    • class MoveFileException
      These were named in alignment with the existing methods in the package. However, there are some inconsistencies across the documentation:

    These naming variations are noted for consistency with the rest of the package, but I believe the current names are clear and follow the existing patterns in the package.

@neves-nvs neves-nvs changed the title Add Support for "Move Workspace File" Endpoint in SendSafely API Add Support for "Move Workspace File" API Endpoint Oct 22, 2024
@neves-nvs
Copy link
Author

neves-nvs commented Oct 23, 2024

@SendSafely-GitHub I would like some feedback on this if possible.
@jhemler If there is any help you could provide, that would be appreciated.

Also, went to look into other packages:

Copy link

@hobelinm hobelinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We tested internally

@SendSafely-GitHub
Copy link
Collaborator

Thank you @neves-nvs and @hobelinm. We have passed this on to our internal team that maintains the Python Client and will let you know once they review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants