update metabase #10

luizbob · 2023-06-14T17:47:44Z

Before submitting the PR, please make sure you do the following

If you're attempting to fix a translation issue, please submit your changes to our POEditor project instead of opening a PR.

Tests

Run the frontend and Cypress end-to-end tests with yarn lint && yarn test)
If there are changes to the backend codebase, run the backend tests with clojure -X:dev:test
Sign the Contributor License Agreement
(unless it's a tiny documentation change).

* add Dan's mb-download script * add short bin/README.md

…52054) * Remove the Cypress "version check" step * Remove superfluous step from GH Actions workflows

* Update mysql.md Add an additional flag as a note, since I've hit this one today with a customer * Update docs/databases/connections/mysql.md Co-authored-by: Jeff Bruemmer <[email protected]> --------- Co-authored-by: Jeff Bruemmer <[email protected]>

This reverts commit bf88842.

* Enabling mouse wheel scroll zooming for leaflet maps * Reducing wheelPxPerZoomLevel so scroll zooming works faster in leaflet maps

…e and positive values (#51941)

* WIP First attempt at passing start of week option to static viz bundle * Cleaning debug lines * set moment and dayjs start of week day setting in static viz * reverting index.ts * Adding backend test for checking first day of week setting is respected in static viz --------- Co-authored-by: Aleksandr Lesnenko <[email protected]> Co-authored-by: Aleksandr Lesnenko <[email protected]>

* Metabase `core` module cleanup * Fix some references

* Remove remaining MetaBot v2 code * Remove reference to metabot v2 mocks

…#49714) * [debug] add storybook helper * Make error on InteractiveQuestion consistent * Make error on StaticQuestion consistent * [debug] static question stories * [debug] InteractiveDashboard Stories * Make error on InteractiveDashboard consistent * [debug] StaticDashboard stories * Make error on StaticDashboard consistent * [debug] EditableDashboard stories * Make error on EditableDashboard consistent * Fix CreateQuestion not working after fixing entity ID states * Add tests for InteractiveQuestion * Add StaticQuestion tests * Add InteractiveDashboard tests * Add StaticDashboard tests * Add EditableDashboard tests * Make variable names consistent * Extract resource not found error to a component * Fix missing return * Make storybook usable and reduce duplications * Don't roll my own util * Update error colors following the new design * Update loki snapshots * Fix unit test expectation to hex * Make colors easier to understand with comments * Update SDK error style * Update error components copy * Use Code from metabase/ui * Remove change accidentally commited * Fix InteractiveQuestion renders question not found briefly #51969

* Remove `metabase.troubleshooting` * Remove Kondo config

* [Backend modularization] Remove `metabase.compatibility` * Fix one more ref

* [Backend modularization] `analyze` module cleanup * Appease Kondo

This change happened in peer #51023 and is manifesting now it seems. The removal of the call to `(classloader/the-classloader)` is what is hurting us. Only clickhouse cloud instances can be set as a suitable upload spot so i'm doing the following changes in the local jar repro to fix it up: ```clojure (in-ns 'metabase.driver.clickhouse) (defmethod driver/database-supports? [:clickhouse :uploads] [_driver _feature db] true) (in-ns 'metabase.public-settings) (let [db_id 2, schema_name "default", table_prefix "upload_"] (t2/update! :model/Database db_id {:uploads_enabled true :uploads_schema_name schema_name :uploads_table_prefix table_prefix})) ```

… tests (#52127)

* [Backend modularization] `query-analysis` cleanup * Update Kondo config * Add CODEOWNERS * metabase.task.sweep-query-analysis => metabase.query-analysis.task.sweep-query-analysis * Move test util * Module linter should ignore my test-setup namespace * Make sure query analysis init is loaded in tests that need it * Deparallelize some of the tests

* Revise new table permissions logic to handle sandboxes * tweak new perm logic * make sure cond has a default * fix comments * tweak defenterprise conditions

* Add ericnormand to query team and slack map * Fix whitespace * Remove trailing whitespace

* allow passing aggregation instead of expression * add e2e test

Closes: #52116 Note that of icu4j was already a dependency, via graalvm. We have just made it explicit now, ~~and updated to the latest version.~~ ([upgrading version breaks rendering](https://github.com/metabase/metabase/actions/runs/12926546646/job/36049844305?pr=52581)) ``` org.graalvm.js/js 22.3.5 . org.graalvm.regex/regex 22.3.5 . org.graalvm.truffle/truffle-api 22.3.5 . com.ibm.icu/icu4j 71.1 . org.graalvm.truffle/truffle-api 22.3.5 . org.graalvm.sdk/graal-sdk 22.3.5 . org.graalvm.sdk/graal-sdk 22.3.5 . com.ibm.icu/icu4j 71.1 ```

* chore: upgrade undici package with a security fix * remove resolution for source-map-js

…52485) * Add lib.native/has-template-tag-variables? * Disable drills for native queries with template tag variables Closes #49051 * Re-export lib.native/has-template-tag-variables? from lib.core * Add tests for disabled drills for native queries with variables * Review feedback

* throw down ui * pixel freaking perfect * wire in real endpoint for fetching dashboard question candidates * wire in move endpoint * loading and error handling for mutation * persist info step acknowledgement * optionally show item in menu, fix flickering of info modal is acked previously, add a toast on successful bulk move * fix some of the failing existing tests * add unit tests for collection menu * add unit tests for main migration modal * add e2e test * fix failing unit test * fix another failing unit test * fix candidates result being stale if dashcards added/removed from dashboards creates/removes candidates * adjust url of feature * copy feedback * fix type-check * scope feature to only admins * use pagination to fetch count but not items when detecting if to show the migration tool menu item * test + style improvements, impl pr feedback * fix unit tests, add unit coverage for is admin

…g a dashboard question (#52406) * adds back prop that prevented feature from working * fix e2e

* mock time using with-redefs * remove parallel * use with-clock

* Add caveat about SDK client filtering Co-authored-by: Jeff Bruemmer <[email protected]>

* Remove &request anaphor and make it a normal arg * Add test * Defendpoint 2.1 * base-handler => handler * Fix Kondo errors

* Auto-rewrite more defendpoints * Test fixes 🔧 * Test fixes 🔧

* Drop Java 11/17 Support * Update Dockerfile Change the Java version of the builder as well * mention that we are dropping support for earlier Java in docs --------- Co-authored-by: Luis Paolini <[email protected]> Co-authored-by: Alexander Solovyov <[email protected]>

Co-authored-by: Noah Moss <[email protected]>

* Make preemptive caching toggle a FE plugin * make sure we expose the premium feature to the FE * fix BE test

* Auto-rewrite sandboxing REST API endpoints * attribute_remappings should be optional * Test fix 🔧

* Remove defendpoint-async * Rewrite all the rest of the remaining defendpoints except for those in public * Remove card endpoints from this PR * Update src/metabase/setup/api.clj Co-authored-by: bryan <[email protected]> * cljfmt * Test fixes 🔧 --------- Co-authored-by: bryan <[email protected]>

@escherize

* defendpoint 2.2 * Remove unused stuff * PR feedback from @escherize

* Auto-rewrite defendpoint forms in session.clj * Auto-rewrite defendpoint forms in session.clj * Revert changes to session * Auto-rewrite endpoints in table.clj * Restore session.clj * OK unrestore session * Fix macroexpansion * Support non-map HTTP request bodies * Remove &request anaphor and make it a normal arg * Add test * Defendpoint 2.1 * base-handler => handler * Fix Kondo errors * Update src/metabase/api/table.clj Co-authored-by: bryan <[email protected]> * Update src/metabase/api/table.clj Co-authored-by: bryan <[email protected]> * no more `&request` --------- Co-authored-by: bryan <[email protected]>

* Auto-rewrite defendpoint forms in session.clj * Auto-rewrite defendpoint forms in session.clj * Remove &request anaphor and make it a normal arg * Add test * Defendpoint 2.1 * base-handler => handler * Fix Kondo errors * Make sure async exception handling is done correctly

camsaul force-pushed the master branch from b5cf03a to 4302573 Compare September 28, 2023 20:10

camsaul force-pushed the master branch from 5498dc1 to e1ebf60 Compare October 6, 2023 23:37

escherize and others added 28 commits January 14, 2025 20:59

add Dan's mb-download script (#51010)

dc5662b

* add Dan's mb-download script * add short bin/README.md

Remove the "version check" from the sequence of Cypress runner steps (#…

6d9d394

…52054) * Remove the Cypress "version check" step * Remove superfluous step from GH Actions workflows

Date widgets types cleanup (#52138)

c05bfd5

perf: Fix performance of CSV pivot table export (#51985)

18cc47e

Update mysql.md (#52139)

5a5cbff

* Update mysql.md Add an additional flag as a note, since I've hit this one today with a customer * Update docs/databases/connections/mysql.md Co-authored-by: Jeff Bruemmer <[email protected]> --------- Co-authored-by: Jeff Bruemmer <[email protected]>

Revert "Revert #52018 to fix failing tests (#52080)" (#52082)

914cc8f

This reverts commit bf88842.

Enabling mouse wheel scroll zooming for leaflet maps (#51888)

fd52f4e

* Enabling mouse wheel scroll zooming for leaflet maps * Reducing wheelPxPerZoomLevel so scroll zooming works faster in leaflet maps

[Backend modularization] xrays module cleanup (#52148)

d6864cb

Removing error boundaries when log scale y axis contains both negativ…

aed32a7

…e and positive values (#51941)

[Backend modularization] Metabase core module cleanup (#52156)

85a341c

* Metabase `core` module cleanup * Fix some references

Remove remaining MetaBot v2 code (#52167)

d59316a

* Remove remaining MetaBot v2 code * Remove reference to metabot v2 mocks

[Backend modularization] Remove metabase.troubleshooting (#52173)

16ea4a7

* Remove `metabase.troubleshooting` * Remove Kondo config

[Backend modularization] Remove metabase.compatibility (#52177)

6a477b5

* [Backend modularization] Remove `metabase.compatibility` * Fix one more ref

[Backend modularization] actions module cleanup (#52170)

ac58570

[Backend modularization] analyze module cleanup (#52179)

a5022e1

* [Backend modularization] `analyze` module cleanup * Appease Kondo

Exclude embedding-sdk/dist for babel-loader for Embedding SDK cypress…

4c197ee

… tests (#52127)

optimize matrix builder (#52101)

6336fdb

ci(sdk): add CODEOWNERS for embedding sdk (#52110)

304e107

fix(sdk): fix data picker crash by using mantine popover (#52096)

6ef8258

Handle stale search index tracking gracefully for h2 (#52084)

c8f684a

Revise new table permissions logic to handle sandboxes (#52052)

0a533a9

* Revise new table permissions logic to handle sandboxes * tweak new perm logic * make sure cond has a default * fix comments * tweak defenterprise conditions

Fix in-progress selection in the date range picker (#52141)

21630de

Add ericnormand to team files (#52143)

aae5c83

* Add ericnormand to query team and slack map * Fix whitespace * Remove trailing whitespace

Run nightly point releases at 4 pm ET (#52197)

5a8d279

uladzimirdev and others added 30 commits January 24, 2025 11:00

fix: allow passing aggregation instead of expression (#52628)

18e423c

* allow passing aggregation instead of expression * add e2e test

Close clause popovers when dnd is active (#52616)

1f7cd46

Remove an empty query stage after a drill from dashboards (#52631)

d9674eb

start prometheus when sending metrics if it was not started yet (#52652)

9543678

Move weight updates to a PUT (#52582)

8473fdb

chore: upgrade undici package with a security fix (#52656)

f81d575

* chore: upgrade undici package with a security fix * remove resolution for source-map-js

Convert LoadingAndErrorWrapper to TS (#52475)

3a8cf25

Mark metrics-search as flaky (#52668)

3155b1c

[Cards in Dashboards] Prevent saving to other dashboards when creatin…

889664c

…g a dashboard question (#52406) * adds back prop that prevented feature from working * fix e2e

Fix flaky date-string->range driver test (#52590)

ff747db

* mock time using with-redefs * remove parallel * use with-clock

Add caveat about SDK client filtering (#52681)

878a67a

* Add caveat about SDK client filtering Co-authored-by: Jeff Bruemmer <[email protected]>

Auto-rewrite defendpoints in channel module (#52632)

b8b539d

Auto-rewrite SCIM endpoints (#52633)

fa3b300

defendpoint 2.1: 3x performance boost (#52647)

768cb95

* Remove &request anaphor and make it a normal arg * Add test * Defendpoint 2.1 * base-handler => handler * Fix Kondo errors

Auto-rewrite even more defendpoints (#52641)

b941c55

* Auto-rewrite more defendpoints * Test fixes 🔧 * Test fixes 🔧

XLSX Export truncate String cells to 32767 chars (#51706)

d83f37e

Co-authored-by: Noah Moss <[email protected]>

note on excel cell limit (#52713)

41a300d

Make preemptive caching toggle a FE plugin (#52131)

d65e48e

* Make preemptive caching toggle a FE plugin * make sure we expose the premium feature to the FE * fix BE test

Auto-rewrite sandboxing REST API endpoints (#52640)

eca1f09

* Auto-rewrite sandboxing REST API endpoints * attribute_remappings should be optional * Test fix 🔧

Rewrite defendpoints in testing.clj and EE saml.clj (#52646)

399e894

defendpoint 2.2: auto-infer route regexes based on schemas (#52649)

91953b7

* defendpoint 2.2 * Remove unused stuff * PR feedback from @escherize

Convert /public endpoints to defendpoint 2, second try (#52715)

1a60acc

Do not clean sandboxing queries (#52710)

bb90936

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update metabase #10

update metabase #10

luizbob commented Jun 14, 2023

update metabase #10

Are you sure you want to change the base?

update metabase #10

Conversation

luizbob commented Jun 14, 2023

Before submitting the PR, please make sure you do the following

Tests