refactor: HomeFragment 리팩토링 #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nueijeel
commented
Mar 26, 2024
nueijeel
commented
- 날짜 관련 함수 Util 객체에서 관리
- UserPreferences, DogPreferences, LoginRepository 객체를 직접 주입하지 않고 ViewModel을 통해 접근
- 불필요한 Job 제거
- 로직 함수화
- 로딩바 관련 버그 해결이 다 안돼서 일단 로딩바 자체를 없앤 상태
- 맨 처음 화면 셋팅 시 가로 달력에 기본값 날짜 표시 안되는 버그 해결 예정
- AccessToken 재발급 로직 추가 - AccessToken과 Provider 값 수정하는 로직 추가 - RefreshToken, Provider, Email flow 객체를 LiveData로 변환
- DogName과 DogId, DogWeight 값 수정하는 로직 추가 - DogWeight flow 객체를 LiveData로 변환
- UserPreferences, DogPreferences, LoginRepository 객체를 직접 주입 받지 않도록 ViewModel 사용 - 불필요한 Job 제거 - 로직 함수화
- 매개변수 개행 - 불필요한 import문 제거 - 불필요한 주석 제거
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.