Avoid the use of important in multi-column dropdown menues #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 11, 2018
|
@ivanhercaz Thanks for your pulls! I am currently sick so I will not be able to deal with them immediately. Hope to do this on Saturday. |
|
You're welcome, Karsten! I hope you recover soon, but please, make a backup of you, because we need you! What you need is to stay some time in the Canary Islands, there is many cold in Germany ☔ ❄️ Enviado desde mi Redmi 4X usando FastHub-Libre |
kghbln
reviewed
Mar 17, 2018
| @media only screen and (min-width: 480px) { | ||
| .dropdown-content { | ||
| left: auto; | ||
| right: 0; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
@ivanhercaz Here we have conflicting code for the same media definition. I do not think this will work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kghbln, after read some posts in StackOverflow I have two theories:
min-width.I made the change based on the second theory. Could you use this code to check if it works fine without
!important? Note that you have to remove theleftandrightfrom.dropdown-content, to be just in media queries.For the user manual, if tomorrow I have a bit of time to dedicate to it, I will make it.