Updated component to version 2.5.0

Semantic-Org · Oct 6, 2022 · 2df5004 · 2df5004
1 parent 579e8b9
commit 2df5004
Show file tree

Hide file tree

Showing 8 changed files with 38 additions and 61 deletions.
diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md
@@ -1,3 +1,7 @@
+### Version 2.5.0 - Oct 6, 2022
+
+- **Modal** - Fixed mutation observer was not properly disconnected
+
 ### Version 2.4.1 - Oct 13, 2018
 
 - **Modal** - Fixed `fullscreen modal` having incorrect left offset with flex modals [#6587](https://github.com/Semantic-Org/Semantic-UI/issues/6587)

diff --git a/composer.json b/composer.json
@@ -5,10 +5,10 @@
   "authors": [{
     "name": "Jack Lukic",
     "email": "[email protected]",
-    "web": "http://www.jacklukic.com",
+    "homepage": "http://www.jacklukic.com",
     "role": "Creator"
   }],
   "keywords": ["semantic", "ui", "css", "framework"],
   "license": "MIT",
-  "version": "2.4.1"
+  "version": "2.5.0"
 }
diff --git a/index.js b/index.js
@@ -1,5 +1,5 @@
 /*!
- * # Semantic UI 2.4.1 - Modal
+ * # Semantic UI 2.5.0 - Modal
  * http://github.com/semantic-org/semantic-ui/
  *
  *
@@ -139,6 +139,9 @@ module.exports = function(parameters) {
         },
 
         destroy: function() {
+          if (observer) {
+            observer.disconnect();
+          }
           module.verbose('Destroying previous modal');
           $module
             .removeData(moduleNamespace)

diff --git a/modal.css b/modal.css
@@ -1,5 +1,5 @@
 /*!
- * # Semantic UI 2.4.0 - Modal
+ * # Semantic UI 2.5.0 - Modal
  * http://github.com/semantic-org/semantic-ui/
  *
  *
@@ -20,13 +20,9 @@
   text-align: left;
   background: #FFFFFF;
   border: none;
-  -webkit-box-shadow: 1px 3px 3px 0px rgba(0, 0, 0, 0.2), 1px 3px 15px 2px rgba(0, 0, 0, 0.2);
-          box-shadow: 1px 3px 3px 0px rgba(0, 0, 0, 0.2), 1px 3px 15px 2px rgba(0, 0, 0, 0.2);
-  -webkit-transform-origin: 50% 25%;
-          transform-origin: 50% 25%;
-  -webkit-box-flex: 0;
-      -ms-flex: 0 0 auto;
-          flex: 0 0 auto;
+  box-shadow: 1px 3px 3px 0px rgba(0, 0, 0, 0.2), 1px 3px 15px 2px rgba(0, 0, 0, 0.2);
+  transform-origin: 50% 25%;
+  flex: 0 0 auto;
   border-radius: 0.28571429rem;
   -webkit-user-select: text;
      -moz-user-select: text;
@@ -81,8 +77,7 @@
   background: #FFFFFF;
   margin: 0em;
   padding: 1.25rem 1.5rem;
-  -webkit-box-shadow: none;
-          box-shadow: none;
+  box-shadow: none;
   color: rgba(0, 0, 0, 0.85);
   border-bottom: 1px solid rgba(34, 36, 38, 0.15);
 }
@@ -105,53 +100,37 @@
   background: #FFFFFF;
 }
 .ui.modal > .image.content {
-  display: -webkit-box;
-  display: -ms-flexbox;
   display: flex;
-  -webkit-box-orient: horizontal;
-  -webkit-box-direction: normal;
-      -ms-flex-direction: row;
-          flex-direction: row;
+  flex-direction: row;
 }
 
 /* Image */
 .ui.modal > .content > .image {
   display: block;
-  -webkit-box-flex: 0;
-      -ms-flex: 0 1 auto;
-          flex: 0 1 auto;
+  flex: 0 1 auto;
   width: '';
-  -ms-flex-item-align: top;
-      align-self: top;
+  align-self: top;
 }
 .ui.modal > [class*="top aligned"] {
-  -ms-flex-item-align: top;
-      align-self: top;
+  align-self: top;
 }
 .ui.modal > [class*="middle aligned"] {
-  -ms-flex-item-align: middle;
-      align-self: middle;
+  align-self: middle;
 }
 .ui.modal > [class*="stretched"] {
-  -ms-flex-item-align: stretch;
-      align-self: stretch;
+  align-self: stretch;
 }
 
 /* Description */
 .ui.modal > .content > .description {
   display: block;
-  -webkit-box-flex: 1;
-      -ms-flex: 1 0 auto;
-          flex: 1 0 auto;
+  flex: 1 0 auto;
   min-width: 0px;
-  -ms-flex-item-align: top;
-      align-self: top;
+  align-self: top;
 }
 .ui.modal > .content > .icon + .description,
 .ui.modal > .content > .image + .description {
-  -webkit-box-flex: 0;
-      -ms-flex: 0 1 auto;
-          flex: 0 1 auto;
+  flex: 0 1 auto;
   min-width: '';
   width: auto;
   padding-left: 2em;
@@ -244,10 +223,7 @@
   }
   /*rtl:ignore*/
   .ui.modal .image.content {
-    -webkit-box-orient: vertical;
-    -webkit-box-direction: normal;
-        -ms-flex-direction: column;
-            flex-direction: column;
+    flex-direction: column;
   }
   .ui.modal .content > .image {
     display: block;
@@ -266,8 +242,7 @@
     width: 100% !important;
     margin: 0em !important;
     padding: 1rem 0rem !important;
-    -webkit-box-shadow: none;
-            box-shadow: none;
+    box-shadow: none;
   }
 
 /* Let Buttons Stack */
@@ -285,8 +260,7 @@
 ---------------*/
 
 .ui.inverted.dimmer > .ui.modal {
-  -webkit-box-shadow: 1px 3px 10px 2px rgba(0, 0, 0, 0.2);
-          box-shadow: 1px 3px 10px 2px rgba(0, 0, 0, 0.2);
+  box-shadow: 1px 3px 10px 2px rgba(0, 0, 0, 0.2);
 }
 
 
@@ -298,8 +272,7 @@
   background-color: transparent;
   border: none;
   border-radius: 0em;
-  -webkit-box-shadow: none !important;
-          box-shadow: none !important;
+  box-shadow: none !important;
   color: #FFFFFF;
 }
 .ui.basic.modal > .header,
@@ -396,9 +369,7 @@
   overflow: hidden;
 }
 .scrolling.dimmable > .dimmer {
-  -webkit-box-pack: start;
-      -ms-flex-pack: start;
-          justify-content: flex-start;
+  justify-content: flex-start;
 }
 .scrolling.dimmable.dimmed > .dimmer {
   overflow: auto;
@@ -427,7 +398,7 @@
 
 /* Scrolling Content */
 .ui.modal .scrolling.content {
-  max-height: calc(70vh);
+  max-height: calc(80vh - 10em);
   overflow: auto;
 }
 
@@ -437,12 +408,8 @@
 
 .ui.fullscreen.modal {
   width: 95% !important;
-  left: 0em !important;
   margin: 1em auto;
 }
-.ui.fullscreen.scrolling.modal {
-  left: 0em !important;
-}
 .ui.fullscreen.modal > .header {
   padding-right: 2.25rem;
 }

diff --git a/modal.js b/modal.js
@@ -1,5 +1,5 @@
 /*!
- * # Semantic UI 2.4.1 - Modal
+ * # Semantic UI 2.5.0 - Modal
  * http://github.com/semantic-org/semantic-ui/
  *
  *
@@ -138,6 +138,9 @@ $.fn.modal = function(parameters) {
         },
 
         destroy: function() {
+          if (observer) {
+            observer.disconnect();
+          }
           module.verbose('Destroying previous modal');
           $module
             .removeData(moduleNamespace)