docs: update rclone configs in sample

Config: no_check_bucket - don't attempt to check the bucket exists or create it This needed if the user you are using does not have bucket creation permissions It's useful when trying to minimise the number of transactions rclone does if you know the bucket exists already Signed-off-by: Viet Nguyen Duc <[email protected]>
SeleniumHQ · Mar 10, 2024 · 5a23107 · 5a23107 · amardeep2006 · Mar 11, 2024
1 parent 5c92a89
commit 5a23107
Show file tree

Hide file tree

Showing 7 changed files with 11 additions and 0 deletions.
diff --git a/README.md b/README.md
@@ -562,6 +562,7 @@ services:
       - RCLONE_CONFIG_S3_ACCESS_KEY_ID=xxx
       - RCLONE_CONFIG_S3_SECRET_ACCESS_KEY=xxx
       - RCLONE_CONFIG_S3_ENDPOINT=https://storage.googleapis.com
+      - RCLONE_CONFIG_S3_NO_CHECK_BUCKET=true
 ```
 
 `SE_VIDEO_FILE_NAME=auto` will use the session id as the video file name. This ensures that the video file name is unique to upload.

diff --git a/charts/selenium-grid/README.md b/charts/selenium-grid/README.md
@@ -527,6 +527,7 @@ videoRecorder:
       RCLONE_CONFIG_MYS3_ACCESS_KEY_ID: "xxx"
       RCLONE_CONFIG_MYS3_SECRET_ACCESS_KEY: "xxx"
       RCLONE_CONFIG_MYS3_ENDPOINT: "https://storage.googleapis.com"
+      RCLONE_CONFIG_MYS3_NO_CHECK_BUCKET: "true"
 ```
 
 Those two ways are equivalent. You can choose one of them or combine them. When both config file and ENV vars are set, value in `upload.conf` will take precedence.

diff --git a/charts/selenium-grid/values.yaml b/charts/selenium-grid/values.yaml
@@ -1080,6 +1080,7 @@ videoRecorder:
     #  RCLONE_CONFIG_S3_ACL: "private"
     #  RCLONE_CONFIG_S3_ACCESS_KEY_ID: "xxx"
     #  RCLONE_CONFIG_S3_SECRET_ACCESS_KEY: "xxx"
+    #  RCLONE_CONFIG_S3_NO_CHECK_BUCKET: "true"
     #  RCLONE_CONFIG_GS_TYPE: "s3"
     #  RCLONE_CONFIG_GS_PROVIDER: "GCS"
     #  RCLONE_CONFIG_GS_ENV_AUTH: "true"
@@ -1089,6 +1090,7 @@ videoRecorder:
     #  RCLONE_CONFIG_GS_ACCESS_KEY_ID: "xxx"
     #  RCLONE_CONFIG_GS_SECRET_ACCESS_KEY: "xxx"
     #  RCLONE_CONFIG_GS_ENDPOINT: "https://storage.googleapis.com"
+    #  RCLONE_CONFIG_GS_NO_CHECK_BUCKET: "true"
   ports:
   - 9000
   resources:

diff --git a/docker-compose-v3-video-upload.yml b/docker-compose-v3-video-upload.yml
@@ -53,6 +53,7 @@ services:
       - RCLONE_CONFIG_S3_ACCESS_KEY_ID=${GS_ACCESS_KEY_ID}
       - RCLONE_CONFIG_S3_SECRET_ACCESS_KEY=${GS_SECRET_ACCESS_KEY}
       - RCLONE_CONFIG_S3_ENDPOINT=https://storage.googleapis.com
+      - RCLONE_CONFIG_S3_NO_CHECK_BUCKET=true
 
   edge_video:
     image: selenium/video:ffmpeg-6.1-20240224
@@ -73,6 +74,7 @@ services:
       - RCLONE_CONFIG_S3_ACCESS_KEY_ID=${GS_ACCESS_KEY_ID}
       - RCLONE_CONFIG_S3_SECRET_ACCESS_KEY=${GS_SECRET_ACCESS_KEY}
       - RCLONE_CONFIG_S3_ENDPOINT=https://storage.googleapis.com
+      - RCLONE_CONFIG_S3_NO_CHECK_BUCKET=true
 
   firefox_video:
     image: selenium/video:ffmpeg-6.1-20240224
@@ -93,6 +95,7 @@ services:
       - RCLONE_CONFIG_S3_ACCESS_KEY_ID=${GS_ACCESS_KEY_ID}
       - RCLONE_CONFIG_S3_SECRET_ACCESS_KEY=${GS_SECRET_ACCESS_KEY}
       - RCLONE_CONFIG_S3_ENDPOINT=https://storage.googleapis.com
+      - RCLONE_CONFIG_S3_NO_CHECK_BUCKET=true
 
   selenium-hub:
     image: selenium/hub:4.18.1-20240224

diff --git a/tests/charts/ci/base-recorder-values.yaml b/tests/charts/ci/base-recorder-values.yaml
@@ -24,6 +24,7 @@ videoRecorder:
       RCLONE_CONFIG_S3_ACL: "private"
       RCLONE_CONFIG_S3_ACCESS_KEY_ID: "${AWS_ACCESS_KEY_ID}"
       RCLONE_CONFIG_S3_SECRET_ACCESS_KEY: "${AWS_SECRET_ACCESS_KEY}"
+      RCLONE_CONFIG_S3_NO_CHECK_BUCKET: "true"
       RCLONE_CONFIG_GS_TYPE: "s3"
       RCLONE_CONFIG_GS_PROVIDER: "GCS"
       RCLONE_CONFIG_GS_ENV_AUTH: "true"
@@ -33,6 +34,7 @@ videoRecorder:
       RCLONE_CONFIG_GS_ACCESS_KEY_ID: "${GS_ACCESS_KEY_ID}"
       RCLONE_CONFIG_GS_SECRET_ACCESS_KEY: "${GS_SECRET_ACCESS_KEY}"
       RCLONE_CONFIG_GS_ENDPOINT: "https://storage.googleapis.com"
+      RCLONE_CONFIG_GS_NO_CHECK_BUCKET: "true"
 
 ingress-nginx:
   controller:

diff --git a/tests/charts/templates/render/dummy.yaml b/tests/charts/templates/render/dummy.yaml
@@ -116,6 +116,7 @@ videoRecorder:
       RCLONE_CONFIG_S3_ACL: "private"
       RCLONE_CONFIG_S3_ACCESS_KEY_ID: "xxx"
       RCLONE_CONFIG_S3_SECRET_ACCESS_KEY: "xxx"
+      RCLONE_CONFIG_S3_NO_CHECK_BUCKET: "true"
 
 nodeConfigMap:
   extraScripts:

diff --git a/tests/charts/templates/render/dummy_solution.yaml b/tests/charts/templates/render/dummy_solution.yaml
@@ -100,6 +100,7 @@ selenium-grid:
         RCLONE_CONFIG_S3_ACL: "private"
         RCLONE_CONFIG_S3_ACCESS_KEY_ID: "xxx"
         RCLONE_CONFIG_S3_SECRET_ACCESS_KEY: "xxx"
+        RCLONE_CONFIG_S3_NO_CHECK_BUCKET: "true"
 
   nodeConfigMap:
     extraScripts: