New Topic Page Playwright Tests #2191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsantacruz
reviewed
Dec 18, 2024
e2e-tests/tests/topics.spec.ts
Outdated
| test('Check redirection for sourceless topic', async ({ context }) => { | ||
| const page = await goToPageWithLang(context, '/topics/Monkey'); | ||
| const expectedUrl = 'search?q=Monkey&tab=sheet&tvar=1&tsort=relevance&stopics_enFilters=Monkey&svar=1&ssort=relevance'; | ||
| await page.waitForTimeout(10000) |
There was a problem hiding this comment.
We should try to avoid timeouts at all costs as they either make the tests brittle (when too short) and greatly increase the run time (when too long). Is there no better way to do this? I think you can await an element on the search page to exist.
e2e-tests/tests/topics.spec.ts
Outdated
|
|
||
| test('Check no redirection when user is admin', async ({ context }) => { | ||
| const page = await goToPageWithUser(context, '/topics/Monkey', testAdminUser); | ||
| await page.waitForTimeout(10000) |
There was a problem hiding this comment.
Same here. Why does the await on line 53 not suffice?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New tests for validation of basic Topic Pages functinality
added new users to test database as well as envionment vars with users data.
Code Changes
The following changes were made to the files below
Notes
Any additional notes go here