Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sc 27327/source click should open in new tab2 #2164

Open
wants to merge 24 commits into
base: feature/sc-27331/new-sidebar-component2
Choose a base branch
from

Conversation

stevekaplan123
Copy link
Contributor

@stevekaplan123 stevekaplan123 commented Dec 10, 2024

Description

This PR implements a small change whereby when a user clicks on a ref in a sheet, it will open in a new tab instead of opening a new panel.

Code Changes

  1. options was unused so I removed that
  2. onCitationClick was no longer necessary to call so I replaced it with a call to window.open

Notes

This should be merged before #2163

…r' into feature/sc-27327/source-click-should-open-in-new-tab
…c-27327/source-click-should-open-in-new-tab2
@stevekaplan123 stevekaplan123 changed the base branch from sheets-viewer-final to feature/sc-27331/new-sidebar-component2 December 10, 2024 10:31
static/js/sheets/Sheet.jsx Outdated Show resolved Hide resolved
static/js/sheets/SheetContent.jsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants