-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Email newsletter sign up forms for sidebar ads #2159
base: master
Are you sure you want to change the base?
Email newsletter sign up forms for sidebar ads #2159
Conversation
… sign-up form for newsletters and provide the option for additional newsletters to be chosen for a specific sidebar ad besides the default ones
…data can flow properly to the sidebar ads for the new newsletter list
|
The available newsletter mailing lists are stored in Salesforce. I made a public API endpoint on the Sefaria side in that PR to retrieve an array of those lists. Strapi will utilize the endpoint to fetch the available mailing lists for people creating sidebar ads. It'll allow them to select which lists users will be subscribed to when those users submit their email addresses. Engineers will also be able to use the endpoint to view the available mailing lists and hard-code specific newsletter subscriptions for their sign-up scenarios. I haven't pushed the changes to the Strapi repo yet.
Only in Strapi right now. I'm also being proactive. MarCom wants to be able to show the available mailing lists in a user's settings and let them subscribe/unsubscribe from there. |
…iple' into feature/sc-29891/add-email-newsletter-signups-for-sidebar
const getLanguageClass = () => (isHebrew ? "int-he" : "int-en"); | ||
|
||
return ( | ||
<OnInView onVisible={() => trackSidebarAdImpression(matchingAd)}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should remove the OnInView component to work with the new analytics module we have created
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll do this in a future PR. Tracking the views of the sidebar ads will not be important for email sign-ups right now
Description
This PR adds the ability for newsletter sign up forms to be added to sidebar ads and for specific newsletter mailing lists to be chosen.
Code Changes
Notes