Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/sc 28761/super about fit and finish page title #2135

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

stevekaplan123
Copy link
Contributor

@stevekaplan123 stevekaplan123 commented Dec 1, 2024

Description

Move position of title for all super about pages.

Code Changes

  1. This required small modificiations in each of the super about pages. Previously, the title DID show up in each super about page in mobile, so I simply removed the code that only let the header be rendered in mobile.
  2. Lots of CSS changes.

Notes

Perhaps the mobileAboutHeader should be re-named to aboutHeader since it now shows both on mobile and desktop. What do you think?

@stevekaplan123 stevekaplan123 marked this pull request as ready for review December 2, 2024 09:35
@stevekaplan123 stevekaplan123 reopened this Dec 2, 2024
templates/metrics.html Show resolved Hide resolved
templates/static/en/about.html Show resolved Hide resolved
templates/metrics.html Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants