Feature/sc 28027/re factor searchresultslist #1943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ria-Project into modularization-main
…ve one type of query not both sheet and text
…nd "sheets with" case
…ure/sc-28260/re-factor-sheetsearchresult
…tsearchresult Feature/sc 28260/re factor sheetsearchresult
nsantacruz
reviewed
Jun 30, 2024
static/js/ReaderPanel.jsx
Outdated
| textSearchState={this.state.textSearchState} | ||
| sheetSearchState={this.state.sheetSearchState} | ||
| type={this.state.searchType} | ||
| searchState={this.state[`${this.state.searchType}SearchState`]} |
There was a problem hiding this comment.
fix tabbing on this line
static/js/SearchResultList.jsx
Outdated
There was a problem hiding this comment.
This is great. Good job deleting unused code and overall simplifying things quite a bit.
nsantacruz
approved these changes
Jun 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In SearchResultList, the prop
typesare no longer an array but rather a string that is either 'text' or 'sheet'. Many state variables in SearchResultList were dictionaries with keys 'text' and 'sheet' and so were refactored as well. There is also no longer a proptaband SearchTabs and updateTab have been removed. In SearchPage and SearchResultList,textSearchStateandsheetSearchStateare collapsed into onesearchStatebut I did not do this throughout the app as I felt this PR was already big enough. I created a new story to address collapsingtextSearchStateandsheetSearchStateintosearchStatethroughout the app.