-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module switcher #1936
Merged
saengel
merged 17 commits into
modularization-main
from
feature/sc-26679/implement-module-switcher-in-main-navigation
Aug 5, 2024
Merged
Module switcher #1936
saengel
merged 17 commits into
modularization-main
from
feature/sc-26679/implement-module-switcher-in-main-navigation
Aug 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edamboritz
reviewed
Jul 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great work
As discussed -
- Lets make the css for the generic component its own. As in separate it out from existing css and give distinct class names rather than ones that existed on the menu used for inspiration
- Lets move out the code for the module switcher into its own component and use that inside the Header render
- We can use above new component to set things things like width that should be flexible on the generic component
Thank you for the helpful feedback @edamboritz - I just finished pushing changes which address all of the above. Let me know what you think now :) |
edamboritz
approved these changes
Aug 4, 2024
saengel
deleted the
feature/sc-26679/implement-module-switcher-in-main-navigation
branch
August 5, 2024 12:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Module switcher first pass for modularization
Code changes:
s2.css
- Styling for the new<DropdownMenu />
generic component, and all of its sub-components. Small shifts to existing code for.interfaceLinks-options
to enable compatibility with the existing language menu dropdown and the new generic dropdown, mostly with using flex for text alignment & switching between languages, as opposed to settingtext-align
static/js/common/DropdownMenu.jsx
- A new file containing a generic dropdown menu (to be reused in the future) that's able to render children as a composable component. Heavily based on the existing code for<InterfaceLanguageMenu />
inMisc.jsx
. The subcomponents are re-usable as well.static/js/Header.jsx
- Added the module switcher next to the language toggle, with the implementation configuration of the composable components in such a way to meet the specs of this specific project.Notes: