Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/sc 26953/frontend for sheets topics component #1928

Merged
merged 75 commits into from
Oct 8, 2024
Merged

Feature/sc 26953/frontend for sheets topics component #1928

merged 75 commits into from
Oct 8, 2024

Conversation

stevekaplan123
Copy link
Contributor

@stevekaplan123 stevekaplan123 commented Jun 16, 2024 •
edited
Loading

Description

This PR implements the core functionality of the Sheets Homepage -- displaying the upcoming parasha, upcoming holiday, and the first level of the topics TOC.

Code Changes

  1. There are no changes to TopicsPage.jsx -- I had originally made a change there but realized it wasn't necessary, but there is simply spacing differences that remain that make it appear in this PR.
  2. The first level of the topics TOC is implemented by the component SheetsTopicsTOC. ReaderApp's setNavigationTopic is passed down the tree to this component so that it can set menuOpen to "topics" to avoid having to call the server in case the topic is in cache.
  3. The parasha and holiday are implemented by the component SheetsCalendar, which gets its data by calling Sefaria.getUpcomingDay(day) where day can be 'holiday' or 'parasha'. ReaderApp's setTopic is passed down the tree to this component so that it can set menuOpen to "topics" to avoid having to call the server in case the topic is in cache.
  4. Mobile design is different than desktop and so multiPanel is passed down to SheetsHomePage to handle the different case.
  5. All topics displayed -- holiday, parasha, and the topics TOC -- are all displayed using the Card component.

@stevekaplan123
chore: started SheetsTopics
a5e68c9
@stevekaplan123
chore: first pass at SheetsTopicTOC
43f712b
@stevekaplan123
Merge branch 'feature/sc-26951/implement-hero-banner' into feature/sc…
6e9bff3 
…-26953/frontend-for-sheets-topics-component
@stevekaplan123
chore: flexbox for sheets page
2f7ac64
@stevekaplan123
fix(Sheets Home Page): allow scroll
19e86b1
@stevekaplan123
Merge branch 'feature/sc-26957/sidebar-with-create-a-sheet-and-educat…
3b40acc 
…ional' into feature/sc-26953/frontend-for-sheets-topics-component
@stevekaplan123
chore: move SheetsTopics to sheets directory
a78105f
@stevekaplan123
chore: undo changes to TopicsPage.jsx
8c2c652
@stevekaplan123
feat(Sheets Home Page): hero banner, main part of topics component, a…
2841800 
…nd sidebar
@stevekaplan123
chore: move Box to GenericComponents
f0e0b48
@stevekaplan123
chore: sheets home page in hebrew
ea36d8f
@stevekaplan123
feat(Sheets Home Page): display in mobile
fa2f1bd
@stevekaplan123
Merge branch 'feature/sc-27518/backend-for-sheets-topics-component' i…
f972b3a 
…nto feature/sc-26953/frontend-for-sheets-topics-component
@stevekaplan123
chore: sheets home page css cleanup
70750f2
@stevekaplan123
chore: write JS code to fetch parashah and holiday for sheets home page
50e3fe0
@stevekaplan123
Merge branch 'feature/sc-27518/backend-for-sheets-topics-component' i…
d072524 
…nto feature/sc-26953/frontend-for-sheets-topics-component
@stevekaplan123
feat(Sheets Home Page): topics, parasha, holiday all load the right text
595e21a
@stevekaplan123
chore: css for sheets topics component but not for mobile and small s…
79bb515 
…creens
@stevekaplan123
chore: sheets homepage small screen css
28fad97
@stevekaplan123
chore: use handleClick in topic toc and holiday but not yet parashah
a5ebb41 
Need to find a way to get the parashah's slug.  Otherwise, setNavigationTopic is impossible to call
@stevekaplan123
Merge branch 'feature/sc-26957/sidebar-with-create-a-sheet-and-educat…
ebc8ae4 
…ional' into feature/sc-26953/frontend-for-sheets-topics-component
@stevekaplan123
Merge branch 'feature/sc-26957/sidebar-with-create-a-sheet-and-educat…
b924010 
…ional' into feature/sc-26953/frontend-for-sheets-topics-component
@stevekaplan123
chore: refactor Card component to use InterfaceText
ae969be
@stevekaplan123
feat(Sheets Home Page): setNavTopic works inconsistently
9210015
@stevekaplan123
chore: css for sheets home page desktop matches figma
3ea0eaa
@stevekaplan123
Merge branch 'feature/sc-27518/backend-for-sheets-topics-component' i…
a4090cf 
…nto feature/sc-26953/frontend-for-sheets-topics-component
@stevekaplan123
chore: use getParashah in SheetsHomePage
7874eb8
@stevekaplan123
Merge branch 'feature/sc-26957/sidebar-with-create-a-sheet-and-educat…
546f66e 
…ional' into feature/sc-26953/frontend-for-sheets-topics-component
@stevekaplan123
feat(Sheets Home Page): dont just load the page, also call setTopic f…
572bf4b 
…or parashah and holiday
@stevekaplan123
chore: fixing layout of mobile sheets home page
50ab8a7
@edamboritz edamboritz changed the base branch from feature/sc-26957/sidebar-with-create-a-sheet-and-educational to modularization-main September 9, 2024 08:29
@stevekaplan123
Merge branch 'feature/sc-26957/sidebar-with-create-a-sheet-and-educat…
341f735 
…ional' into feature/sc-26953/frontend-for-sheets-topics-component
@stevekaplan123
chore: make sheets homepage css clearer
ebe35d8
@stevekaplan123
chore: only put a line above a card on sheetshomepage so that it look…
cd6f54d 
…s like two columns
@stevekaplan123
chore: remove shadow for hero banner text
c0c3f89
@stevekaplan123
chore: move to single panel at 840 instead of 800 or 600
e3954c3
@stevekaplan123
chore: use contentInner to style sheetsTopics to make it look like te…
e015633 
…xts and topics pages
@stevekaplan123
Merge branch 'feature/sc-26957/sidebar-with-create-a-sheet-and-educat…
3b230c1 
…ional' into feature/sc-26953/frontend-for-sheets-topics-component
@stevekaplan123
chore: create 4 states of screen width
c3ced8f
@stevekaplan123
Merge branch 'modularization-main' into feature/sc-26953/frontend-for…
7800422 
…-sheets-topics-component
@stevekaplan123
chore: general solution to 4 screen states using class table
97fc0ae
@stevekaplan123
chore: fix navsidebar's margin top in sheets homepage
6b3e9f3
@stevekaplan123
chore: explicitly use table class for above 900 and between 600 and 700
f865527
@stevekaplan123
chore: sheets URL should be able to have / appended to it
9fb6b96
@stevekaplan123
chore: cleanup card css in sheets homepage
f0af4ea
@stevekaplan123
chore: use clearer syntax for nth child pseudochild
fa3dcf8
edamboritz
edamboritz previously approved these changes Oct 1, 2024
View reviewed changes
@stevekaplan123 stevekaplan123 dismissed stale reviews from edamboritz and edamboritz October 1, 2024 10:28

The merge-base changed after approval.

edamboritz
edamboritz previously approved these changes Oct 1, 2024
View reviewed changes
@akiva10b akiva10b merged commit 7019aff into modularization-main Oct 8, 2024
16 checks passed
@stevekaplan123 stevekaplan123 deleted the feature/sc-26953/frontend-for-sheets-topics-component branch October 8, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edamboritz edamboritz edamboritz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevekaplan123 @edamboritz @akiva10b