fix(search bar): enable search with input from virtual keyboard #1921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rd on blur using downshift setInputValue function
nsantacruz
reviewed
Jun 24, 2024
static/js/Autocomplete.jsx
Outdated
| setSearchFocused, searchFocused, | ||
| submitSearch, redirectToObject}) => { | ||
|
|
||
| const getInputValue = () =>{ | ||
| return otherDownShiftProps.value || document.getElementsByClassName('keyboardInput')[0].value; |
There was a problem hiding this comment.
this function should use getVirtualKeyboardInputValue()
There was a problem hiding this comment.
Also, this is very dangerous since you're getting the first instance of a CSS class. If this class is used by some other element this could break. Can you come up with a more specific CSS selector?
nsantacruz
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes synchronicity between virtual keyboard and search bar