Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Replaced Image.network with CachedNetworkImage #270

Conversation

yousufmyk
Copy link

@yousufmyk yousufmyk commented Feb 28, 2024

Description

Replaced Image.network with CachedNetworkImage

Related Issue

closes #255

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code refactor
  • Build configuration change
  • Documentation
  • Chore

@divyanshub024 divyanshub024 self-requested a review February 28, 2024 12:10
Copy link
Contributor

@divyanshub024 divyanshub024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @yousufmyk 👋🏻

Thank you for the amazing contribution. I have some suggestions, please check my comments.

@divyanshub024
Copy link
Contributor

@yousufmyk There are some formatting issues in mirai_image_parser can you please check?

@divyanshub024 divyanshub024 added this to the v0.7 milestone Feb 28, 2024
@yousufmyk
Copy link
Author

Done, You can check now

@divyanshub024
Copy link
Contributor

divyanshub024 commented Feb 28, 2024

Thanks a lot, @yousufmyk, There is still some issue with the formatting. Can you please check?

Format check is failing: https://github.com/Securrency-OSS/mirai/actions/runs/8080252574/job/22077116041?pr=270

@yousufmyk
Copy link
Author

I see, I've tried fixing Dart formatting Issues. Hopefully, now it should work fine.

@yousufmyk
Copy link
Author

@divyanshub024 don’t know why this keeps failing I tried "dart format --set-exit-if-changed ." and it works but again getting an issue do you have any idea about this issue?

@divyanshub024
Copy link
Contributor

@yousufmyk
Can you try running the following commands?

Make sure you have Melos installed in your system:

dart pub global activate melos

And then run

1. melos clean
2. melos bs
3. melos format

@yousufmyk
Copy link
Author

@divyanshub024 Thank you for the suggestions! appreciate you taking the time to help troubleshoot.

I've now installed Melos and run the commands you provide.

@yousufmyk
Copy link
Author

I can see it’s again failing but on my side it says "
melos run format
└> melos exec -- "dart format ."
└> SUCCESS" after running melos

@divyanshub024
Copy link
Contributor

@yousufmyk Can you run flutter pub get in mirai_gallery? When I ran it pubspec.lock file showed some changes. Alternatively, you can also run melos bs from the root folder.

@divyanshub024 divyanshub024 changed the title feat: Replaced Image.network with CachedNetworkImage. #255 feat: Replaced Image.network with CachedNetworkImage Feb 28, 2024
@divyanshub024
Copy link
Contributor

@yousufmyk Can you run flutter pub get in mirai_gallery? When I ran it pubspec.lock file showed some changes. Alternatively, you can also run melos bs from the root folder.

Hey @yousufmyk, Did it help?

@divyanshub024 divyanshub024 modified the milestones: v0.7, v0.8 Mar 5, 2024
@divyanshub024
Copy link
Contributor

Closed by #289

@divyanshub024 divyanshub024 removed this from the v0.8 milestone Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Replace Image.network with CachedNetworkImage.
2 participants