-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Replaced Image.network with CachedNetworkImage #270
feat: Replaced Image.network with CachedNetworkImage #270
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @yousufmyk 👋🏻
Thank you for the amazing contribution. I have some suggestions, please check my comments.
packages/mirai/lib/src/parsers/mirai_image/mirai_image_parser.dart
Outdated
Show resolved
Hide resolved
@yousufmyk There are some formatting issues in |
Done, You can check now |
Thanks a lot, @yousufmyk, There is still some issue with the formatting. Can you please check? Format check is failing: https://github.com/Securrency-OSS/mirai/actions/runs/8080252574/job/22077116041?pr=270 |
I see, I've tried fixing Dart formatting Issues. Hopefully, now it should work fine. |
@divyanshub024 don’t know why this keeps failing I tried "dart format --set-exit-if-changed ." and it works but again getting an issue do you have any idea about this issue? |
@yousufmyk Make sure you have Melos installed in your system:
And then run
|
@divyanshub024 Thank you for the suggestions! appreciate you taking the time to help troubleshoot. I've now installed Melos and run the commands you provide. |
I can see it’s again failing but on my side it says " |
@yousufmyk Can you run |
Hey @yousufmyk, Did it help? |
Closed by #289 |
Description
Replaced Image.network with CachedNetworkImage
Related Issue
closes #255
Type of Change