feat: Add Mirai Switch #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @divyanshub024 , @i-asimkhan. First of all, it was great working on MIRAI and with no due time I was able to adde the support to have a This is not the full implementation, there are some more addition, which has been added in the TBD section and also need to discuss on those points. |
kushalmahapatro
force-pushed
the
feature/add-switch
branch
from
1a5c1b2 to
064e846
Compare
i-asimkhan
reviewed
Sep 18, 2023
There was a problem hiding this comment.
Thank you very much for this @kushalmahapatro I have a few suggestions in the comments comparing other parts of the widgets parsers in MIrai.
packages/mirai/lib/src/parsers/mirai_switch/mirai_switch_parser.dart
Outdated
Show resolved
Hide resolved
divyanshub024
suggested changes
Sep 18, 2023
There was a problem hiding this comment.
Thanks a lot, @kushalmahapatro for this PR. Please check my comments.
packages/mirai/lib/src/parsers/mirai_switch/cubit/mirai_switch_cubit.dart
Outdated
Show resolved
Hide resolved
kushalmahapatro
force-pushed
the
feature/add-switch
branch
from
b7b3b91 to
1fc0107
Compare
kushalmahapatro
changed the title
i-asimkhan
approved these changes
Sep 25, 2023
i-asimkhan
requested changes
Sep 25, 2023
divyanshub024
suggested changes
Sep 25, 2023
packages/mirai/lib/src/parsers/mirai_switch/widget/mirai_switch_widget_state.dart
Outdated
Show resolved
Hide resolved
kushalmahapatro
force-pushed
the
feature/add-switch
branch
from
e25416d to
3f70210
Compare
divyanshub024
approved these changes
Sep 30, 2023
There was a problem hiding this comment.
@kushalmahapatro Thank you so much for this valuable PR. 💯 🙏🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for switch in Mirai.
This basically takes up an initial value and a listener onChanged.
The state of the switch is being handled by
MiraiSwitchCubit.This is a draft PR raised to confirm that we are following the right practices and to verify if this is the correct approach for handling the state.
TBD
onChanged. (network call / updating value in shared preference or storage etc.)Related Issues
feat: Add support for Switch in Mirai #168
Type of Change