feat: Added support for font family using fonts from assets and G-Fonts #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added mirai text theme data in Mirai theme - Added mirai font family parser - Added font resource type enum
|
Hey @RodolfoSilva I have come up with something called This is great because it detects whether to load the font from the assets or through http (google_fonts) |
I loved this solution @i-asimkhan . It's more extensible... |
Signed-off-by: Divyanshu Bhargava <[email protected]>
There was a problem hiding this comment.
@i-asimkhan Can we remove the Lisu font and only keep the Handjet(Regular, medium & bold)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for font family using fonts from assets and G-Fonts
Related Issues
Closes #118
Type of Change