Add pivot to reflow #144
Merged
Add pivot to reflow #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allows attaching the reflowed element anywhere from the anchor point
Uriopass
force-pushed
the
reflow_pivot
branch
from
f4fc03f to
555a270
Compare
LPGhatguy
approved these changes
Mar 16, 2024
There was a problem hiding this comment.
This is a good change! I like your rationale for the introduction of the new type.
I'd like to revisit which layout widgets we have and how they're composed soon. I think that'd be good to do as part of a holistic layout pass since I think there's a lot of merging to do.
Uriopass
added a commit
to Uriopass/yakui
that referenced
this pull request
Jun 30, 2024
allows attaching the reflowed element anywhere from the anchor point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows reflowing while taking into account the child size. I personally need this to be able to show a tooltip over a button (when hovered for a bit) that is nicely centered.
I introduced a new "Pivot" type to avoid accidentally swapping the anchor and the pivot arguments in the
reflowshorthand.Another idea: This could be implemented as a separate
Pivotwidget with the same offset logic.Could also be added to the
Offsetwidget which would now also take relative (pivot) coordinates.(Could be worth simplifying
Flow::Relativeremoving offset since the Offset widget can already do this?)Some screenshots:
Backward compat: Pivot is
TOP_LEFT.Pivot is 'CENTER':
Pivot is equal to anchor:
