yakui-vulkan cleanup and simplification #107
Conversation
Ralith
force-pushed
the
vulkan-updates
branch
6 times, most recently
from
9909a0a to
6d95688
Compare
Ralith
force-pushed
the
vulkan-updates
branch
from
6d95688 to
5f2c2fe
Compare
|
Ideally I think @kanerogers should be the one to review this since he's using the actively Vulkan backend and has a lot more experience with it. Going forward, I'd be cool setting up CODEOWNERS so both of you can land fixes and features to the backend without waiting on me. |
|
Sorry, I've been away for the last two weeks and have tried not to look at emails! Will give this a review this week. Happy to be the owner for the Vulkan backend. |
| @@ -173,3 +180,164 @@ fn get_filter(yakui_filter: yakui::paint::TextureFilter) -> vk::Filter { | |||
| yakui::paint::TextureFilter::Nearest => vk::Filter::NEAREST, | |||
| } | |||
| } | |||
|
|
|||
| #[derive(Default)] | |||
| pub(crate) struct UploadQueue { | |||
Ralith
force-pushed
the
vulkan-updates
branch
from
5f2c2fe to
42fa439
Compare
Ralith
force-pushed
the
vulkan-updates
branch
from
42fa439 to
a47dff5
Compare
|
@Ralith @kanerogers |
| @@ -388,6 +388,7 @@ impl YakuiVulkan { | |||
| /// | |||
| /// ## Safety | |||
| /// - `vulkan_context` must be the same as the one used to create this [`YakuiVulkan`] instance | |||
| /// - `cmd` must be in rendering state, with viewport and scissor dynamic states set. | |||
There was a problem hiding this comment.
I was going to quibble on this one with "well we should update the docs to tell the developer they need to.." but unfortunately you were one step ahead of me. 😛
This should be much easier to use and more composable.