bugfix

SeanLee97 · Sep 30, 2024 · a9cc91e · a9cc91e
1 parent 157dacc
commit a9cc91e
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/angle_emb/angle.py b/angle_emb/angle.py
@@ -1531,7 +1531,6 @@ def fit(self,
             dataset_format=self.detect_dataset_format(train_ds),
             train_dataset=train_ds,
             eval_dataset=valid_ds,
-            do_eval=valid_ds is not None,
             loss_kwargs=loss_kwargs,
             tokenizer=self.tokenizer,
             args=TrainingArguments(
@@ -1542,10 +1541,11 @@ def fit(self,
                 learning_rate=learning_rate,
                 fp16=fp16,
                 logging_steps=logging_steps,
+                save_steps=save_steps,
                 save_strategy=save_strategy,
+                do_eval=valid_ds is not None,
                 evaluation_strategy=evaluation_strategy,
                 eval_steps=eval_steps,
-                save_steps=save_steps,
                 output_dir=output_dir,
                 save_total_limit=save_total_limit,
                 load_best_model_at_end=False,