Make sure password strength hint is visible

src/pretalx/cfp/forms/auth.py

@@ -1,7 +1,7 @@
 from django import forms
 from django.core.exceptions import ValidationError
 
-from pretalx.common.forms.fields import PasswordConfirmationField, PasswordField
+from pretalx.common.forms.fields import NewPasswordConfirmationField, NewPasswordField
 from pretalx.common.text.phrases import phrases
 from pretalx.person.models import User
 
@@ -25,8 +25,8 @@ def clean(self):
 
 
 class RecoverForm(forms.Form):
-    password = PasswordField(label=phrases.base.new_password, required=False)
-    password_repeat = PasswordConfirmationField(
+    password = NewPasswordField(label=phrases.base.new_password, required=False)
+    password_repeat = NewPasswordConfirmationField(
         label=phrases.base.password_repeat,
         required=False,
         confirm_with="password",

src/pretalx/common/forms/fields.py

@@ -25,7 +25,7 @@ def __call__(self, value):
         return validate_password(value)
 
 
-class PasswordField(CharField):
+class NewPasswordField(CharField):
     default_validators = [GlobalValidator()]
 
     def __init__(self, *args, **kwargs):
@@ -35,7 +35,7 @@ def __init__(self, *args, **kwargs):
         super().__init__(*args, **kwargs)
 
 
-class PasswordConfirmationField(CharField):
+class NewPasswordConfirmationField(CharField):
     def __init__(self, *args, **kwargs):
         kwargs["widget"] = kwargs.get(
             "widget",

src/pretalx/common/forms/widgets.py

@@ -45,6 +45,7 @@ def render(self, name, value, attrs=None, renderer=None):
         )
 
         self.attrs = add_class(self.attrs, "password_strength")
+        self.attrs["autocomplete"] = "new-password"
         return mark_safe(super().render(name, value, self.attrs) + markup)
 
 

src/pretalx/common/templates/common/auth.html

@@ -19,9 +19,8 @@
 
 {% compress js %}
     <script defer src="{% static "vendored/zxcvbn.js" %}"></script>
-    <script defer src="{% static "common/js/base.js" %}"></script>
-    <script defer src="{% static "common/js/password_strength.js" %}"></script>
     <script defer src="{% static "common/js/formTools.js" %}"></script>
+    <script defer src="{% static "common/js/password_strength.js" %}"></script>
 {% endcompress %}
 
 {% if not hide_login %}

src/pretalx/person/forms.py

@@ -11,8 +11,8 @@
 from pretalx.cfp.forms.cfp import CfPFormMixin
 from pretalx.common.forms.fields import (
     ImageField,
-    PasswordConfirmationField,
-    PasswordField,
+    NewPasswordConfirmationField,
+    NewPasswordField,
     SizeFileField,
 )
 from pretalx.common.forms.mixins import (
@@ -53,12 +53,11 @@ class UserForm(CfPFormMixin, forms.Form):
         required=False,
         widget=forms.EmailInput(attrs={"autocomplete": "email"}),
     )
-    register_password = PasswordField(
+    register_password = NewPasswordField(
         label=_("Password"),
         required=False,
-        widget=forms.PasswordInput(attrs={"autocomplete": "new-password"}),
     )
-    register_password_repeat = PasswordConfirmationField(
+    register_password_repeat = NewPasswordConfirmationField(
         label=_("Password (again)"),
         required=False,
         confirm_with="register_password",
@@ -299,8 +298,8 @@ class LoginInfoForm(forms.ModelForm):
     old_password = forms.CharField(
         widget=forms.PasswordInput, label=_("Password (current)"), required=True
     )
-    password = PasswordField(label=phrases.base.new_password, required=False)
-    password_repeat = PasswordConfirmationField(
+    password = NewPasswordField(label=phrases.base.new_password, required=False)
+    password_repeat = NewPasswordConfirmationField(
         label=phrases.base.password_repeat, required=False, confirm_with="password"
     )