Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint title #530

Merged
merged 17 commits into from
Feb 20, 2024
Merged

maint title #530

merged 17 commits into from
Feb 20, 2024

Conversation

RogueStationAI
Copy link

No description provided.

SkyratBot and others added 17 commits February 20, 2024 01:00
museum away mission (#81208)

adds a new gateway map, the Nanotrasen Museum it is filled with
""""Mannequins"""" and Common Core lore
im not putting the preview here because you really should explore it
yourself but if youre that curious i think the Checks tab in mapdiffbot
would have it
this gateway map contains no combat unless you count falling into chasms
because you did not carry a light
or going into the boarded room with no loot or any incentive with
obvious signs that there is the sole enemy on the map in there
the loot is the lore ok thanks

also makes mines detonate if theyre detonated by a non-mob im pretty
sure this couldnt have been intentional
trams stop chasms
and also the relevant items

<details>
  <summary>on second thought if you want spoilers check this</summary>

![image](https://github.com/tgstation/tgstation/assets/70376633/41ab2db1-55ce-4371-8594-a1d8961c37c3)

</details>

more gateway maps = good

:cl:
add: nanotrasen museum gateway map
/:cl:

---------

Co-authored-by: jimmyl <[email protected]>
Co-authored-by: MrMelbert <[email protected]>
Co-authored-by: Ghom <[email protected]>
…nds. Keeps tts from killing servers. (Skyrat-SS13#26501)

* Moves inter-round caches to cache/. Deletes tmp/ between rounds. Keeps tts from killing servers. (#81433)

* Moves inter-round caches to cache/. Deletes tmp/ between rounds. Keeps tts from killing servers.

---------

Co-authored-by: Kyle Spier-Swenson <[email protected]>
* TGchat: Tweaks & Fixes (#81354)

## About The Pull Request
1. Case Sensitive highlight has been fixed, it works now
2. Added `Clear Chat` button, clears the active tab. Code stolen from
GoonStation closed PR
goonstation/goonstation#16708
3. Added `Mute` button, it allows to switch off Unread counter on
separate tabs
4. Cyrillic is supported by highlights again
5. Small appearance edits, unfortunately dropdowns are just as bad
6. Buttons when pressed no longer remain highlighted as if you were
hovering over them, which was slightly misleading and generally looked
like a bug (I'l revert it if you say so)

## Why It's Good For The Game
You can mute individual tabs so they don't clutter your eyes, clear chat
if you need to and create Case Sensitive highlights, isn't that nice?

## Images of Changes

<details>
<summary>Case Sensitive</summary>

https://github.com/tgstation/tgstation/assets/69762909/1123049c-05e1-4110-82de-79c2f807453f

</details>
<details>
<summary>Clear Chat</summary>

https://github.com/tgstation/tgstation/assets/69762909/6ac91d08-2a22-435e-974d-7386ade77b77

</details>
<details>
<summary>Mute Button</summary>

https://github.com/tgstation/tgstation/assets/69762909/394dbe46-2e6f-4217-840c-d9a7ebaff566

</details>

## Changelog

:cl: Aylong
add: Added `Mute` button into `Chat Tabs` settings, it disables tab
unread counter
add: Added `Clear chat` button into `General` settings, you can clear
your dirty chat like you did it before TGchat
fix: Case-sensitive highlighting now works properly
/:cl:

* TGchat: Tweaks & Fixes

---------

Co-authored-by: Aylong <[email protected]>
… KREKS, McRamon) (Skyrat-SS13#26493)

Resprites changeling abilities and weapons (By MelokGleb and KREKS, McRamon)

Co-authored-by: Ghom <[email protected]>
MuleBOT UI/ID Fixes (#81380)

## About The Pull Request

- Fixes tgstation/tgstation#81363
- Fixes unable to set MuleBOT home from control panel
- Fixes missing MuleBOT ID from Botkeeper PDA app
- Adds input validation for changing MuleBOT ID from control panel
- Removes hardcoding of MuleBOT IDs and home destinations
- MuleBOT will now automatically set its home to the navigation beacon
on its initialization turf

## Changelog

:cl: LT3
fix: MULEbot will correctly display its loaded cargo on BotKeeper
fix: MULEbot home beacon can be set from control panel
code: MULEbot home location is automatically set on init
/:cl:

Co-authored-by: lessthanthree <[email protected]>
Co-authored-by: Useroth <[email protected]>
* Nuka Cola causes irradiation (#81362)

## About The Pull Request

Nuka Cola now causes irradiation.

## Why It's Good For The Game

Most of our speed bonuses, such as Methamphetamine, comes with a
downside (the usual one being brain damage), because speed is king.

When you give people a speed boost that comes with absolutely NO
downsides outside of visual, it turns out people abuse it, a lot.

Even a small speed boost ends up being abused. It is not uncommon to see
security officers saddled with two, three bottles. Nor is it uncommon to
see tiders use it to escape said officers, or antags to escape said
tiders. Do you see the problem here? It has become a situation where not
having it puts you at a disadvantage, which is sad.

Irradiation fits thematically, too. And it also shows you when someone's
using it, since they start glowing green.

## Changelog

:cl: Melbert
balance: Scientists have discovered Nuka Cola is not good for short term
health.
/:cl:

* Nuka Cola causes irradiation

---------

Co-authored-by: MrMelbert <[email protected]>
…ustom) only having digi apply when custom could be applied (Skyrat-SS13#26507)

* woo

* this isnt even tg code what am i doing bro
* Refactors how machines are deconstructed (#81291)

## About The Pull Request
This refactors how machines are deconstructed in the following ways

- You can no longer override `obj/machinery/deconstruct()`. If you want
customized behaviour then override `on_deconstruction()` instead.

This comes with the added benifit of no longer needing to check for the
`NO_DECONSTRUCTION` flag because the machine base proc does that for us
& if it finds that flag it won't proceed to call `on_deconstruction()`
meaning no machine will have a chance to spawn anything which is the
current behaviour.

This is required to make #81290 work for all machines at least so that
machine can send the `COMSIG_OBJ_DECONSTRUCT` signal without subtypes
overriding & forgetting to call the parent proc

- `dump_contents()` only gets called when the machine is deconstructed
not destroyed thus not leaving behind any of its contents inside. Fixes
tgstation/tgstation#81290 (comment)

## Changelog
:cl:
fix: machines that should not drop contents when deleted no longer do.
refactor: refactors how machines are deconstructed. report bugs on
github.
/:cl:

---------

Co-authored-by: MrMelbert <51863163+MrMelbert@ users.noreply.github.com>

* Refactors how machines are deconstructed

* is this it?

---------

Co-authored-by: SyncIt21 <[email protected]>
Co-authored-by: MrMelbert <51863163+MrMelbert@ users.noreply.github.com>
Co-authored-by: Useroth <[email protected]>
@ORCACommander ORCACommander merged commit 405a610 into master Feb 20, 2024
6 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants