Add tests for invalid JSON for definition in request #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfisher-scottlogic
requested review from
pling-scottlogic and
vferraro-scottlogic
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
If we're going to add these tests for the Layouts resource, it's probably worth doing the same for Application Layouts. |
cfisher-scottlogic
force-pushed
the
SLVUU-tests-for-definition-json
branch
from
ec590a2 to
c96bcb3
Compare
cfisher-scottlogic
changed the base branch from
VUU333-layout-server
to
main
cfisher-scottlogic
force-pushed
the
SLVUU-tests-for-definition-json
branch
from
c96bcb3 to
af3e6ae
Compare
Done! af3e6ae |
pling-scottlogic
approved these changes
Nov 23, 2023
vferraro-scottlogic
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#81 refactored the type of
LayoutRequestDTO.definitiontoObjectNodeto enforce a valid JSON constraint. A couple of new tests to ensure this enforcement is successful are missing. This PR adds those tests, and possibly highlights the need for better exception handling of this issue to provide a cleaner error message.