Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check recipient addresses for ENS confusables in batch send #640

Merged
merged 12 commits into from
Feb 13, 2024

Conversation

jferas
Copy link
Contributor

@jferas jferas commented Jan 22, 2024

Resolves #551
Resolves #530

Copy link

netlify bot commented Jan 22, 2024

Deploy Preview for jolly-shaw-20fe62 ready!

Name Link
🔨 Latest commit 94cbb6b
🔍 Latest deploy log https://app.netlify.com/sites/jolly-shaw-20fe62/deploys/65cbcc75da3d7a0008835819
😎 Deploy Preview https://deploy-preview-640--jolly-shaw-20fe62.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jferas jferas force-pushed the bug/confusables-warning-batch branch 2 times, most recently from 80dc6e8 to 9ec4185 Compare January 23, 2024 18:58
@jferas jferas marked this pull request as ready for review January 23, 2024 19:16
frontend/src/pages/AccountSend.vue Outdated Show resolved Hide resolved
frontend/src/pages/AccountSend.vue Outdated Show resolved Hide resolved
frontend/src/pages/AccountSend.vue Outdated Show resolved Hide resolved
@jferas jferas force-pushed the bug/confusables-warning-batch branch from 34740c2 to e435b88 Compare January 25, 2024 18:34
@jferas jferas requested a review from alexkeating January 25, 2024 20:51
Copy link
Collaborator

@alexkeating alexkeating left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A couple nits and this should be ready

@jferas jferas requested a review from alexkeating January 30, 2024 19:32
@jferas jferas force-pushed the bug/confusables-warning-batch branch from 62a4bf2 to 8459e97 Compare January 31, 2024 17:31
@jferas jferas force-pushed the bug/confusables-warning-batch branch from 1f3618a to 462fac7 Compare February 8, 2024 17:55
Copy link
Member

@garyghayrat garyghayrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks John!

@garyghayrat garyghayrat force-pushed the bug/confusables-warning-batch branch from 5052009 to 94cbb6b Compare February 13, 2024 20:09
Copy link

Coverage after merging bug/confusables-warning-batch into master will be

81.10%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
contracts-periphery/src
   UmbraBatchSend.sol100%100%100%100%
   UniswapWithdrawHook.sol100%100%100%100%
umbra-js/src
   ethers.ts76.27%100%61.11%100%
   types.ts50%100%0%100%
umbra-js/src/classes
   KeyPair.ts98.65%96.49%100%100%31–32
   RandomNumber.ts100%100%100%100%
   StealthKeyRegistry.ts100%100%100%100%
   TxHistoryProvider.ts77.55%76.47%66.67%79.31%11, 11, 19–20, 31, 38, 44, 53, 57, 8
   Umbra.ts75.21%63.01%82.93%81.95%103, 132–133, 154, 226–228, 312–315, 377, 391, 398–400, 402–403, 406–407, 425, 427, 429, 429, 429, 429–430, 430, 430–432, 447, 447, 447–448, 452, 455, 475, 493–494, 581, 598, 611–612, 622–623, 636, 639–640, 670–671, 747, 751, 751, 751–754, 754, 754, 754, 754, 754, 754–755, 755, 755, 755, 755, 755, 755, 755, 755, 755, 755, 757, 757, 757–758, 761, 761, 761, 761, 761–762, 765, 774, 774, 783, 786, 786, 786–788, 801, 805, 808–809, 815–817, 824, 824, 824–827, 858, 863–864, 864–865
umbra-js/src/typechain
   index.ts70.59%100%37.50%100%
umbra-js/src/typechain/factories
   index.ts100%100%100%100%
umbra-js/src/typechain/factories/@OpenZeppelin
   index.ts100%100%100%100%
umbra-js/src/typechain/factories/@openzeppelin/contracts
   index.ts100%100%100%100%
umbra-js/src/typechain/factories/@openzeppelin/contracts/access
   Ownable__factory.ts50%100%0%66.67%70, 76
   index.ts50%100%0%100%
umbra-js/src/typechain/factories/@openzeppelin/contracts/token
   index.ts100%100%100%100%
umbra-js/src/typechain/factories/@openzeppelin/contracts/token/ERC20
   ERC20__factory.ts29.03%0%12.50%47.06%310, 314, 314, 314–315, 317, 326, 326, 326, 333, 333, 333, 336, 339, 345
   IERC20__factory.ts50%100%0%66.67%201, 204
   index.ts50%100%0%100%
umbra-js/src/typechain/factories/contracts
   IUmbraHookReceiver__factory.ts50%100%0%66.67%61, 67
   MockHook__factory.ts22.58%0%0%41.18%107, 111, 111, 111–112, 114, 121, 121, 121, 126, 126, 126, 129, 132, 138, 144
   StealthKeyRegistry__factory.ts22.58%0%0%41.18%202, 206, 206, 206–207, 209, 216, 216, 216, 221, 221, 221, 224, 227, 233, 239
   TestToken__factory.ts64.52%66.67%50%70.59%329–330, 348, 351, 354, 360, 366
   Umbra__factory.ts70.97%66.67%62.50%76.47%495–496, 525, 529, 532, 538
   index.ts50%100%0%100%
umbra-js/src/utils
   cns.ts50%33.33%50%55%33–36, 40, 40, 40, 40, 40–41, 44–46
   constants.ts100%100%100%100%
   ens.ts36.11%25%33.33%40%25–27, 35, 56–57, 57, 57–58, 63–64, 66, 70, 70, 70, 70, 70–71, 75–77
   utils.ts76.67%68.66%76.92%82%109–111, 113–115, 121, 139–140, 169, 190, 246, 253–260, 260, 260, 260, 260, 260, 260–261, 263, 294, 296–297, 306, 306, 306–307, 309, 312, 321–322, 363, 380, 380, 380, 400, 429, 431, 436, 448, 448–449, 454, 456–457, 468–472, 478, 480, 522–523, 523, 523–525, 525, 525, 536, 59–60, 779–780, 792–793, 85, 93, 93
umbra-js/test
   testPrivateKeys.ts100%100%100%100%
   utils.ts100%100%100%100%

@garyghayrat garyghayrat merged commit b1816ba into master Feb 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants