Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update network names to fix CI #635

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Update network names to fix CI #635

merged 3 commits into from
Dec 18, 2023

Conversation

garyghayrat
Copy link
Member

No description provided.

Copy link

netlify bot commented Dec 15, 2023

Deploy Preview for jolly-shaw-20fe62 ready!

Name Link
🔨 Latest commit a8ab298
🔍 Latest deploy log https://app.netlify.com/sites/jolly-shaw-20fe62/deploys/6580c523ce70480008a00090
😎 Deploy Preview https://deploy-preview-635--jolly-shaw-20fe62.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@garyghayrat garyghayrat force-pushed the fix-ci-update-foundry-toml branch from afa5fae to c834a72 Compare December 15, 2023 15:19
@garyghayrat garyghayrat requested a review from apbendi December 15, 2023 19:18
@jferas jferas self-requested a review December 15, 2023 20:53
Copy link
Contributor

@jferas jferas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Coverage after merging fix-ci-update-foundry-toml into master will be

81.12%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
contracts-periphery/src
   UmbraBatchSend.sol100%100%100%100%
   UniswapWithdrawHook.sol100%100%100%100%
umbra-js/src
   ethers.ts88.24%100%78.57%100%
   types.ts50%100%0%100%
umbra-js/src/classes
   KeyPair.ts98.65%96.49%100%100%31–32
   RandomNumber.ts100%100%100%100%
   StealthKeyRegistry.ts100%100%100%100%
   TxHistoryProvider.ts77.55%76.47%66.67%79.31%11, 11, 19–20, 31, 38, 44, 53, 57, 8
   Umbra.ts75.21%63.01%82.93%81.95%103, 132–133, 154, 228–230, 314–317, 379, 393, 400–402, 404–405, 408–409, 427, 429, 431, 431, 431, 431–432, 432, 432–434, 449, 449, 449–450, 454, 457, 477, 495–496, 583, 600, 613–614, 624–625, 638, 641–642, 672–673, 749, 753, 753, 753–756, 756, 756, 756, 756, 756, 756–757, 757, 757, 757, 757, 757, 757, 757, 757, 757, 757, 759, 759, 759–760, 763, 763, 763, 763, 763–764, 767, 776, 776, 785, 788, 788, 788–790, 803, 807, 810–811, 817–819, 826, 826, 826–829, 860, 865–866, 866–867
umbra-js/src/typechain
   index.ts70.59%100%37.50%100%
umbra-js/src/typechain/factories
   index.ts100%100%100%100%
umbra-js/src/typechain/factories/@OpenZeppelin
   index.ts100%100%100%100%
umbra-js/src/typechain/factories/@openzeppelin/contracts
   index.ts100%100%100%100%
umbra-js/src/typechain/factories/@openzeppelin/contracts/access
   Ownable__factory.ts50%100%0%66.67%70, 76
   index.ts50%100%0%100%
umbra-js/src/typechain/factories/@openzeppelin/contracts/token
   index.ts100%100%100%100%
umbra-js/src/typechain/factories/@openzeppelin/contracts/token/ERC20
   ERC20__factory.ts29.03%0%12.50%47.06%310, 314, 314, 314–315, 317, 326, 326, 326, 333, 333, 333, 336, 339, 345
   IERC20__factory.ts50%100%0%66.67%201, 204
   index.ts50%100%0%100%
umbra-js/src/typechain/factories/contracts
   IUmbraHookReceiver__factory.ts50%100%0%66.67%61, 67
   MockHook__factory.ts22.58%0%0%41.18%107, 111, 111, 111–112, 114, 121, 121, 121, 126, 126, 126, 129, 132, 138, 144
   StealthKeyRegistry__factory.ts22.58%0%0%41.18%202, 206, 206, 206–207, 209, 216, 216, 216, 221, 221, 221, 224, 227, 233, 239
   TestToken__factory.ts64.52%66.67%50%70.59%329–330, 348, 351, 354, 360, 366
   Umbra__factory.ts70.97%66.67%62.50%76.47%495–496, 525, 529, 532, 538
   index.ts50%100%0%100%
umbra-js/src/utils
   cns.ts50%33.33%50%55%33–36, 40, 40, 40, 40, 40–41, 44–46
   constants.ts100%100%100%100%
   ens.ts36.11%25%33.33%40%25–27, 35, 56–57, 57, 57–58, 63–64, 66, 70, 70, 70, 70, 70–71, 75–77
   utils.ts76.73%68.66%76.92%82.09%109–111, 113–115, 121, 139–140, 169, 190, 246, 253–260, 260, 260, 260, 260, 260, 260–261, 263, 294, 296–297, 306, 306, 306–307, 309, 312, 321–322, 348, 366, 366, 366, 386, 415, 417, 422, 434, 434–435, 440, 442–443, 454–458, 464, 466, 508–509, 509, 509–511, 511, 511, 522, 59–60, 765–766, 778–779, 85, 93, 93
umbra-js/test
   testPrivateKeys.ts100%100%100%100%
   utils.ts100%100%100%100%

Copy link
Member

@apbendi apbendi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @garyghayrat

@apbendi apbendi merged commit 9bd4900 into master Dec 18, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants