Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test propose, queue, execute, cancel functions #52

Merged
merged 3 commits into from
Nov 4, 2024
Merged

Test propose, queue, execute, cancel functions #52

merged 3 commits into from
Nov 4, 2024

Conversation

garyghayrat
Copy link
Member

No description provided.

@garyghayrat garyghayrat linked an issue Nov 1, 2024 that may be closed by this pull request
Let's test both methods for cancel together (full TVCD args as well as proposalId args), and also queue, execute #53
Closed
@garyghayrat garyghayrat requested a review from jferas November 4, 2024 02:25
@garyghayrat garyghayrat marked this pull request as ready for review November 4, 2024 02:25
jferas
jferas requested changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@jferas jferas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.. only thing I can think to add would be tests for the functions queue, execute, and cancel that take proposal ID as a parameter and verify that they revert properly if passed an invalid proposal ID.

wildmolasses
wildmolasses approved these changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@wildmolasses wildmolasses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, @garyghayrat, exactly what i was looking for!

contracts/test/CompoundGovernor.t.sol Outdated Show resolved Hide resolved
contracts/test/CompoundGovernor.t.sol Outdated Show resolved Hide resolved
contracts/test/CompoundGovernor.t.sol Outdated Show resolved Hide resolved
@wildmolasses wildmolasses merged commit 8c5d88b into main Nov 4, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jferas jferas jferas requested changes

@wildmolasses wildmolasses wildmolasses approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@garyghayrat @jferas @wildmolasses