forked from compound-finance/compound-governance
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature - Enumerable proposal ids #33
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11483405126Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
jferas
force-pushed
the
feat/enum-proposal-ids
branch
from
October 18, 2024 19:12
136daec
to
12664b3
Compare
jferas
force-pushed
the
feat/enum-proposal-ids
branch
from
October 21, 2024 15:22
4843313
to
902a103
Compare
jferas
force-pushed
the
feat/enum-proposal-ids
branch
from
October 23, 2024 15:41
bbfc2cf
to
4389890
Compare
jferas
force-pushed
the
feat/enum-proposal-ids
branch
from
October 23, 2024 16:43
4389890
to
e838f98
Compare
…vernorStorageUpgradeable.. still need to override _propose to emit enumerable proposal ID
for emitting enumerable proposal ID.
jferas
force-pushed
the
feat/enum-proposal-ids
branch
from
October 23, 2024 17:27
e838f98
to
1f54293
Compare
Using alternate implementation from #43 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #9