Added test framework with minimal deploy script #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11221809554Details
💛 - Coveralls |
wildmolasses
approved these changes
Oct 7, 2024
| contract CompoundGovernorConstants { | ||
| // These constants are taken from the existing GovernorBravoDelegate contract. | ||
|
|
||
| uint48 INITIAL_VOTING_DELAY = 13_140; // The delay before voting takes place, in blocks |
There was a problem hiding this comment.
hey @jferas how confident are we that these are the constants we're going live with? should we put a TODO here (or better, an issue to verify these initialization params)?
|
|
||
| function setUp() public virtual { | ||
| // private key of the deployer (use the anvil default account #0 key, if no environment variable is set) | ||
| deployerPrivateKey = vm.envOr( |
There was a problem hiding this comment.
is it possible to avoid setting a PK in the env? Would prefer to let foundry manage the wallet instead. We run across this often, and i remember there's a limitation with calling scripts in tests. maybe this is something we can create an issue for.
wildmolasses
pushed a commit
that referenced
this pull request
Nov 1, 2024
* feat: proposal guardian * remove `.only` * create new `proposalGuardian` role * add tests * Update comments per recommendation * feat: proposal guardian expires * lint `GovernorBravoDelegate` * feat: expose guardian expiration (#17)
wildmolasses
pushed a commit
that referenced
this pull request
Nov 1, 2024
* Added test framework with minimal deploy script * forge fmt constant cleanup * Added TODO about constants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5