expv error estimate: hermitian only #165
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Currently, krylov_phiv_error_estimate.jl only implements the Lanczos algorithm for Hermitian matrix, which gives a tridiagonal H to use with the expT! functiopns's stegr call
ExponentialUtilities.jl/src/krylov_phiv_error_estimate.jl
Line 29 in 18e5161
This PR passes on the
ishermitian
argument and errors if false.Fixes #160
--
whitespace changes is with JuliaFormatter's sciml style.