-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
37 - Resolving QWidget issues #38
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mxochicale for looking into this. I think that should solve the problems that @younes1010 identified. At the moment the github actions are failing. I'd like to try and sort that before approving/merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @mxochicale. I've made some changes to get tests passing. Minor change to conda notes: we shouldn't need to install the development requirements to run the tutorial.
Hi @thompson318 @MattClarkson
There might other bits to update but I think I fixed #37 by updating pyside2 to pyside6 and adding missing vtk steps
self.vtk_overlay_window.Initialize()
andself.vtk_overlay_window.Start()
. Would you please review it!Some other pending bits might be:
Thanks,
Miguel