WIP: feat: add permission check #395
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Junjiequan
requested changes
Nov 29, 2024
nitrosx
requested changes
Dec 2, 2024
Comment on lines
8
to
12
| directory: config.testData.directory || "", | ||
| dataset: "", | ||
| file0: config.testData?.files[0] || "", | ||
| file1: config.testData?.files[1] || "", | ||
| file2: config.testData?.files[2] || "", |
There was a problem hiding this comment.
The current configuration allows to download files only from a single dataset.
Should we consider to change the data structure here to allow multi dataset, multi files download?
Or should we keep it as it is in this PR and consider it for future a one?
There was a problem hiding this comment.
where in SciCat can you download files from multiple datasets?
There was a problem hiding this comment.
Not at the moment, but it is coming
Junjiequan
reviewed
Dec 10, 2024
src/auth.ts
Outdated
Comment on lines
94
to
102
| const valid = await dataSetAPI.datasetsControllerFindById({pid: authRequest.dataset}).then( | ||
| (value) => | ||
| { | ||
| if(value.isPublished || // Check if proposal is public | ||
| value.accessGroups.some(item => new Set(authRequest.jwt.groups).has(item)) || // Check if user has one or more of the access groups of dataset | ||
| authRequest.jwt.groups.indexOf(value.ownerGroup) > -1) //Check if user has the owner group | ||
| { | ||
| return true; | ||
| } |
There was a problem hiding this comment.
Suggested change
| const valid = await dataSetAPI.datasetsControllerFindById({pid: authRequest.dataset}).then( | |
| (value) => | |
| { | |
| if(value.isPublished || // Check if proposal is public | |
| value.accessGroups.some(item => new Set(authRequest.jwt.groups).has(item)) || // Check if user has one or more of the access groups of dataset | |
| authRequest.jwt.groups.indexOf(value.ownerGroup) > -1) //Check if user has the owner group | |
| { | |
| return true; | |
| } | |
| const isPublic = value.isPublished; | |
| const hasAccessGroup = value.accessGroups.some(item => new Set(authRequest.jwt.groups).has(item)); | |
| const hasOwnerGroup = authRequest.jwt.groups.includes(value.ownerGroup); | |
| if (isPublic || hasAccessGroup || hasOwnerGroup) { | |
| return true; | |
| } |
It'd be easier to read this way, what do you think?
There was a problem hiding this comment.
The suggested codes should be inside the curly bracket.
Co-authored-by: Jay <[email protected]>
nitrosx
reviewed
Dec 11, 2024
Comment on lines
+94
to
+99
| const isPublic = value.isPublished; | ||
| const hasAccessGroup = value.accessGroups.some(item => new Set(authRequest.jwt.groups).has(item)); | ||
| const hasOwnerGroup = authRequest.jwt.groups.includes(value.ownerGroup); | ||
| if (isPublic || hasAccessGroup || hasOwnerGroup) { | ||
| return true; | ||
| } |
There was a problem hiding this comment.
Where is value coming from?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should not be merged until final package of sdk-typescript for scicat is released