Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yaml linting to CI, update all docker compose files to respect rules #95

Merged
merged 6 commits into from
Mar 28, 2024

Conversation

consolethinks
Copy link
Contributor

@consolethinks consolethinks commented Mar 27, 2024

partially addresses #82

@consolethinks consolethinks requested a review from minottic March 28, 2024 08:20
docker-compose.yaml Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reading the docs, I've seen there's also the option:

required: only-when-needed

Maybe that puts less requirements whenever adding a new module.

I think we can merge it like this, and I will do the changes in another PR

@minottic minottic self-requested a review March 28, 2024 09:29
@minottic minottic merged commit 682654f into SciCatProject:master Mar 28, 2024
1 check passed
@consolethinks consolethinks deleted the update_ci branch April 9, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants