Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ENV var to control DEV workdir mount to host #396

Merged
merged 5 commits into from
Dec 13, 2024
Merged

Add ENV var to control DEV workdir mount to host #396

merged 5 commits into from
Dec 13, 2024

Conversation

minottic
Copy link
Contributor

using unison the bbackup folder on the host and the workdir in the container are synchronized (both ways)

Copy link
Contributor

@rkweehinzmann rkweehinzmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@minottic minottic merged commit 3986594 into main Dec 13, 2024
15 checks passed
@minottic minottic deleted the host_sync branch December 13, 2024 12:39
@sbliven
Copy link
Contributor

sbliven commented Dec 16, 2024

I'd like to discuss this more. Duplicating the data storage doesn't seem like the most efficient solution when we have mounts available. And unison can use a significant amount of resources for big changes like git checkouts.

@minottic
Copy link
Contributor Author

sure, I think in person will be a little easier. High-level, the reason is: if you use mount points, it is hard to sync subsequent docker compose up -d with different ENVs, as different ENVs will need to write to different container dirs not to conflict. But then I think it would be confusing to have the changes separate, and so we would need to find a way to merge them. I implemented an alternative solution here: #384 but it had this problem. If we revise it slightly we could maybe use that instead of unison. I liked unison as it also does a backup, not only a local dev (and makes sure to keep everything in sync)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants