Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update schema validation from oneOf to anyOf for dataset creation and updates #1544

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

Junjiequan
Copy link
Contributor

@Junjiequan Junjiequan commented Dec 9, 2024

Description

This PR aims to fix the python SDK issue #1533 raised by @emigun

Motivation

Based on the official documentation it is suggested to use anyOf to validate when there's one or more fields are shared across the combined schemas.

Fixes

  • Bug fixed (#X)

Changes:

  • changes made

Tests included

  • Included for each change/fix?
  • Passing?

Documentation

  • swagger documentation updated (required for API changes)
  • official documentation updated

official documentation info

@martin-trajanovski martin-trajanovski changed the title fix: update schema validation from oneOf to anyOf for dataset creatio… fix: update schema validation from oneOf to anyOf for dataset creation and updates Dec 10, 2024
@emigun emigun self-requested a review December 10, 2024 07:34
Copy link
Contributor

@emigun emigun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@Junjiequan Junjiequan merged commit 3b4f602 into master Dec 10, 2024
8 checks passed
@Junjiequan Junjiequan deleted the python-sdk-oneOf-error branch December 10, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants