Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delete_job_groups instance authorization #1534

Open
wants to merge 3 commits into
base: release-jobs
Choose a base branch
from

Conversation

sofyalaski
Copy link
Contributor

@sofyalaski sofyalaski commented Nov 27, 2024

Description

When in .env delete-job-group was set to admin, flowing the authorization logic, admin should be able to delete a job. Instead, this user would get denied access.

Motivation

fix this

Fixes

user can delete a job based on delete-job-group

Changes:

  • In casl, the endpoint authorization lines for JobDelete are separated into their own if/else clauses
  • added admin to delete_job_group in tests workflow
  • 1920 test shour return a successful status code
  • test for getting are adapted to minus one deleted test.

Tests included

  • Included for each change/fix?
  • Passing?

Documentation

  • swagger documentation updated (required for API changes)
  • official documentation updated

Copy link
Contributor

@sbliven sbliven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@sofyalaski
Copy link
Contributor Author

Thanks for the fix!

then I will create another PR for scicatlive. there was a change in env for tests again..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants