Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement metrics tracking system[proof of concept] #1504

Conversation

Junjiequan
Copy link
Contributor

…us integration

Description

Motivation

Fixes

  • Bug fixed (#X)

Changes:

  • changes made

Tests included

  • Included for each change/fix?
  • Passing?

Documentation

  • swagger documentation updated (required for API changes)
  • official documentation updated

official documentation info

@Junjiequan Junjiequan added the feature New feature label Nov 14, 2024
@bpedersen2
Copy link
Contributor

+1

@Junjiequan Junjiequan changed the title feat: implement metrics tracking and aggregation system with Promethe… feat: implement metrics tracking system[proof of concept] Nov 15, 2024
Copy link
Contributor

@bpedersen2 bpedersen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally a good idea.
and +1 for using prometheus compat metrics

@Junjiequan
Copy link
Contributor Author

Closing this PR as the idea was rejected
New PR is opened for alternative #1559

@Junjiequan Junjiequan closed this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants