Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store configVersion in the job schema #1364

Merged
merged 6 commits into from
Sep 3, 2024

Conversation

despadam
Copy link

@despadam despadam commented Aug 7, 2024

Description

As seen in issue #1341

Motivation

Since we are now using a global job configuration - instead of job specific - we should only store the configuration version inside each job in the db.

Changes:

  • job.schema was updated to only include configVersion
  • In jobs.controller: instanceAuthorizationJobCreate and was updated to store configVersion in jobInstance

Tests:

Tests should be updated to conform with the new job schema and retrieve the configuration from elsewhere.

@despadam despadam marked this pull request as ready for review August 7, 2024 14:53
@despadam despadam requested a review from sofyalaski August 7, 2024 14:53
@despadam despadam self-assigned this Aug 7, 2024
src/jobs/jobs.controller.ts Outdated Show resolved Hide resolved
@Junjiequan Junjiequan self-requested a review August 8, 2024 12:33
@Junjiequan Junjiequan dismissed their stale review August 8, 2024 12:35

Commented issues are fixed

@Junjiequan Junjiequan removed their request for review August 30, 2024 13:52
…1395)

* wip cherry-picking commits

* wip: casl for job instances before adding argument with jobConfig

* merged cherry-picked commit that splits casl, jobs authorization requires two arguments, the new being the jobConfig property. Casl for jobs instances is restructred to use it in the if statements instead of configuration being part of jobInstance

* fix linting

* proposals pass tests
@despadam despadam merged commit e8287f6 into release-jobs Sep 3, 2024
7 checks passed
@despadam despadam deleted the store-configVersion-in-job-schema branch September 3, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants