Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: updated configuration for new FE datafiles actions #1346

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

nitrosx
Copy link
Contributor

@nitrosx nitrosx commented Jul 29, 2024

Description

This PR updates the example files containing the FE configuration with the new keys needed for new FE datafiles actions.

Motivation

In order to make the FE more flexible, FE PR #1528 adds configurable datafiles actions. I norder to be compatible with the new FE, the BE needs to have an updated FE configuration which contains such new keys

Changes:

  • src/config/frontend.config.json

Tests included

  • Included for each change/fix? NOT NEEDED.
  • Passing? (Merge will not be approved unless this is checked) NOT NEEDED

Documentation

  • swagger documentation updated [required] NOT NEEDED
  • official documentation updated [nice-to-have] NOT NEEDED

official documentation info

If you have updated the official documentation, please provide PR # and URL of the pages where the updates are included

Documentation added in the FE repo

Copy link
Contributor

@Junjiequan Junjiequan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@@ -112,7 +112,7 @@
"maxDirectDownloadSize": 5000000000,
"metadataPreviewEnabled": true,
"metadataStructure": "",
"multipleDownloadAction": "https://scicatfileserver.esss.dk/zip",
"multipleDownloadAction": "http:/127.0.0.1:3012/zip",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to include ZipService image in the docker file later as well then

/CI/E2E/docker-compose-local.yaml

@Junjiequan Junjiequan changed the title updated configuration for new FE datafiles actions build: updated configuration for new FE datafiles actions Jul 29, 2024
@Junjiequan Junjiequan force-pushed the fe-configuration-datafiles-actions branch from ed920c5 to 9a167f5 Compare July 29, 2024 16:22
@nitrosx nitrosx merged commit 70f98b5 into master Jul 29, 2024
7 checks passed
@nitrosx nitrosx deleted the fe-configuration-datafiles-actions branch July 29, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants