fix unit test for users controller

SciCatProject · Sep 18, 2024 · f891727 · f891727
1 parent 0e73c70
commit f891727
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/users/users.controller.spec.ts b/src/users/users.controller.spec.ts
@@ -75,7 +75,7 @@ describe("UsersController", () => {
     const result = await controller.getSettings(mockRequest as Request, userId);
 
     // Assert
-    expect(result?.externalSettings).toEqual(mockUserSettings);
+    expect(result).toEqual(mockUserSettings);
     expect(result?.externalSettings?.filters).toBeDefined();
     expect(
       (result?.externalSettings?.filters as Record<string, unknown>).length,
@@ -108,7 +108,7 @@ describe("UsersController", () => {
     const expectedResponse: UserSettings = {
       ...updatedSettings,
       _id: userId,
-      userId: userId, // Ensure all required properties are included
+      userId: userId,
       datasetCount: updatedSettings.datasetCount,
       jobCount: updatedSettings.jobCount,
       externalSettings: updatedSettings.externalSettings,
@@ -124,7 +124,7 @@ describe("UsersController", () => {
       updatedSettings,
     );
 
-    expect(result?.externalSettings).toEqual(updatedSettings);
+    expect(result).toEqual(expectedResponse);
     expect(result?.externalSettings?.filters).toBeDefined();
     expect(
       (result?.externalSettings?.filters as Record<string, unknown[]>).length,