update pyscicat ingestion documentation #54
Conversation
mkywall
commented
Oct 23, 2023
mkywall
commented
- use updated method names
- use OrigDataBlockDTO
- use model_dump for updated pydantic
- add information about attachments that are too large
Updates from new release and then headers untab
print response content
| @@ -7,12 +7,12 @@ To begin with: | |||
| from datetime import datetime | |||
| from pathlib import Path | |||
|
|
|||
| from pyscicat.client import encode_thumbnail, ScicatClient | |||
| from pyscicat.client import encode_thumbnail, ScicatClient,CreateDatasetOrigDatablockDto | |||
There was a problem hiding this comment.
unrelated change, but probably OK here.
| @@ -146,24 +160,24 @@ dataset = Dataset( | |||
| sourceFolder="/foo/bar", | |||
| scientificMetadata={"a": "field"}, | |||
| sampleId="gargleblaster", | |||
| **ownable.dict()) | |||
There was a problem hiding this comment.
You probably did this because of a deprecation warning, but pydantic has been have growing pains. If you do this, pin the version of pydantic in setup.cfg to >= 2.0
There was a problem hiding this comment.
This might be a difficult PR to merge, but I think it's worth it. However, pydantic is going to have to get pinned to 2.0 or above for this to work. I think it's time to do that pin. The pydantic migration has been horrible, but we are at the point where we make it hard for pyscicat to be integration with a variety of tools by not going all-in on it. Pinning to 2.0 will be more explicit. [edited to clarify pydantic is currently supported, but 2.0 pin will be explicit]
