Skip to content

Commit

Permalink
destroy fixtures to prevent random unit test failures
Browse files Browse the repository at this point in the history
  • Loading branch information
garethcmurphy committed Sep 24, 2018
1 parent 8c54445 commit 9092376
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 12 deletions.
4 changes: 4 additions & 0 deletions src/app/dashboard/dashboard.component.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@ describe("DashboardComponent", () => {
fixture.detectChanges();
});

afterEach(() => {
fixture.destroy();
});

it("should be created", () => {
console.log ("should be created");
expect(component).toBeTruthy();
Expand Down
6 changes: 4 additions & 2 deletions src/app/dataset-detail/dataset-detail.component.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import {
MockPublishedDataApi
} from "../MockStubs";
import { NgxJsonLdModule } from "@ngx-lite/json-ld";
import { PublishedDataApi } from "../shared/sdk/services/custom";
import { RouterTestingModule } from "@angular/router/testing";
import { async, ComponentFixture, TestBed } from "@angular/core/testing";

Expand All @@ -31,7 +30,6 @@ describe("DatasetDetailComponent", () => {
declarations: [DatasetDetailComponent, FileSizePipe],
providers: [
{ provide: HttpClient, useClass: MockHttp },
{ provide: PublishedDataApi, useClass: MockPublishedDataApi },
{ provide: DatasetService, useClass: MockDatasetService },
{ provide: NgxJsonLdModule, useClass: MockNgx },
{ provide: APP_CONFIG }
Expand All @@ -46,6 +44,10 @@ describe("DatasetDetailComponent", () => {
fixture.detectChanges();
});

afterEach(() => {
fixture.destroy();
});

it("should be created", () => {
expect(component).toBeTruthy();
});
Expand Down
10 changes: 5 additions & 5 deletions src/app/datasets/datasets.component.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,7 @@ import { HttpClient } from "@angular/common/http";
import { InMemoryDataService } from "../in-memory-data.service";
import { InMemoryWebApiModule } from "angular-in-memory-web-api";
import { MatCardModule } from "@angular/material";
import { MockDatasetService, MockHttp, MockPublishedDataApi } from "../MockStubs";
import { NgxDatatableModule } from "@swimlane/ngx-datatable";
import { PublishedDataApi } from "../shared/sdk/services/custom";
import { MockDatasetService, MockHttp } from "../MockStubs";
import { RouterTestingModule } from "@angular/router/testing";
import { async, ComponentFixture, TestBed } from "@angular/core/testing";

Expand All @@ -19,14 +17,12 @@ describe("DatasetsComponent", () => {
TestBed.configureTestingModule({
imports: [
RouterTestingModule,
NgxDatatableModule,
MatCardModule,
InMemoryWebApiModule.forRoot(InMemoryDataService)
],
declarations: [DatasetsComponent],
providers: [
{ provide: HttpClient, useClass: MockHttp },
{ provide: PublishedDataApi, useClass: MockPublishedDataApi },
{ provide: DatasetService, useClass: MockDatasetService },
{ provide: APP_CONFIG }
]
Expand All @@ -40,6 +36,10 @@ describe("DatasetsComponent", () => {
fixture.detectChanges();
});

afterEach(() => {
fixture.destroy();
});

it("should be created", () => {
expect(component).toBeTruthy();
});
Expand Down
6 changes: 1 addition & 5 deletions src/app/datasets/datasets.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,10 @@ import { Component, Inject, OnInit } from "@angular/core";
import { DatasetService } from "../dataset.service";
import { PublishedData } from "../shared/sdk/models";
import { APP_CONFIG, AppConfig } from "../app-config.module";
import { HttpClient, HttpHeaders } from "@angular/common/http";
import { HttpClient } from "@angular/common/http";
import { map } from "rxjs/operators";
import { Router } from "@angular/router";

const httpOptions = {
headers: new HttpHeaders({ "Content-Type": "application/json" })
};

interface MyType {
doi: string;
value: string;
Expand Down

0 comments on commit 9092376

Please sign in to comment.